You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/01/09 19:09:31 UTC

[GitHub] [trafficcontrol] mitchell852 opened a new pull request #4274: TP: adds tr request and response header fields to steering* ds forms

mitchell852 opened a new pull request #4274: TP: adds tr request and response header fields to steering* ds forms
URL: https://github.com/apache/trafficcontrol/pull/4274
 
 
   ## What does this PR (Pull Request) do?
   
   - [x] This PR fixes #4271 
   
   ## Which Traffic Control components are affected by this PR?
   
   - Traffic Portal
   
   ## What is the best way to verify this PR?
   Create a STEERING or CLIENT_STEERING delivery service and ensure that the TR Request / Response Headers are listed under Routing Configuration Settings.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   
   - master (0c04aac)
   - 4.0.0 (RC1)
   
   ## The following criteria are ALL met by this PR
   
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4274: TP: adds tr request and response header fields to steering* ds forms

Posted by GitBox <gi...@apache.org>.
mitchell852 commented on a change in pull request #4274: TP: adds tr request and response header fields to steering* ds forms
URL: https://github.com/apache/trafficcontrol/pull/4274#discussion_r364913870
 
 

 ##########
 File path: traffic_portal/app/src/common/modules/form/deliveryService/edit/FormEditDeliveryServiceController.js
 ##########
 @@ -202,10 +202,13 @@ var FormEditDeliveryServiceController = function(deliveryService, origin, type,
 				if (options.status.id == $scope.COMPLETE) {
 					createDeliveryServiceUpdateRequest(dsRequest, options.comment, true).then(
 						function() {
-							deliveryServiceService.updateDeliveryService(deliveryService);
-						}).then(function() {
-							$state.reload(); // reloads all the resolves for the view
-							messageModel.setMessages([ { level: 'success', text: 'Delivery Service [ ' + deliveryService.xmlId + ' ] updated' } ], false);
+							deliveryServiceService.updateDeliveryService(deliveryService).
 
 Review comment:
   I mistakenly branched off another branch that has a PR that has yet to be merged. Once PR#4273 is merged. This diff should go away.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rawlinp merged pull request #4274: TP: adds tr request and response header fields to steering* ds forms

Posted by GitBox <gi...@apache.org>.
rawlinp merged pull request #4274: TP: adds tr request and response header fields to steering* ds forms
URL: https://github.com/apache/trafficcontrol/pull/4274
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4274: TP: adds tr request and response header fields to steering* ds forms

Posted by GitBox <gi...@apache.org>.
mitchell852 commented on a change in pull request #4274: TP: adds tr request and response header fields to steering* ds forms
URL: https://github.com/apache/trafficcontrol/pull/4274#discussion_r364913870
 
 

 ##########
 File path: traffic_portal/app/src/common/modules/form/deliveryService/edit/FormEditDeliveryServiceController.js
 ##########
 @@ -202,10 +202,13 @@ var FormEditDeliveryServiceController = function(deliveryService, origin, type,
 				if (options.status.id == $scope.COMPLETE) {
 					createDeliveryServiceUpdateRequest(dsRequest, options.comment, true).then(
 						function() {
-							deliveryServiceService.updateDeliveryService(deliveryService);
-						}).then(function() {
-							$state.reload(); // reloads all the resolves for the view
-							messageModel.setMessages([ { level: 'success', text: 'Delivery Service [ ' + deliveryService.xmlId + ' ] updated' } ], false);
+							deliveryServiceService.updateDeliveryService(deliveryService).
 
 Review comment:
   I mistakenly branched off another branch that has a PR that has yet to be merged. Once PR#4273 is merged. This should go away.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services