You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Igal Shilman (JIRA)" <ji...@apache.org> on 2012/05/23 16:24:41 UTC
[jira] [Created] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Igal Shilman created HBASE-6071:
-----------------------------------
Summary: getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
Key: HBASE-6071
URL: https://issues.apache.org/jira/browse/HBASE-6071
Project: HBase
Issue Type: Improvement
Components: client, ipc
Affects Versions: 0.90.4
Reporter: Igal Shilman
Priority: Minor
HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
[~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461533#comment-13461533 ]
Hadoop QA commented on HBASE-6071:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12546227/HBASE-6071.v5.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
-1 javadoc. The javadoc tool appears to have generated 139 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2925//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2925//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2925//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2925//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2925//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2925//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2925//console
This message is automatically generated.
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: Client, IPC/RPC
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Attachments: HBASE-6071.patch, HBASE-6071.v2.patch, HBASE-6071.v3.patch, HBASE-6071.v4.patch, HBASE-6071.v5.patch, HConnectionManager_HBASE-6071-0.90.0.patch, lease-exception.txt
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "Igal Shilman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igal Shilman updated HBASE-6071:
--------------------------------
Attachment: HBASE-6071.v5.patch
Attaching a version, that logs unsuccessful attempts only if withRetires() exits abnormally (neither returns a value, nor RetriesExhaustedException is thrown).
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: Client, IPC/RPC
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Attachments: HBASE-6071.patch, HBASE-6071.v2.patch, HBASE-6071.v3.patch, HBASE-6071.v4.patch, HBASE-6071.v5.patch, HConnectionManager_HBASE-6071-0.90.0.patch, lease-exception.txt
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13282821#comment-13282821 ]
Zhihong Yu commented on HBASE-6071:
-----------------------------------
--no-prefix is not required now - Hadoop QA is smart.
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: client, ipc
> Affects Versions: 0.90.0, 0.92.0, 0.94.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Attachments: HConnectionManager_HBASE-6071-0.90.0.patch
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "Igal Shilman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460429#comment-13460429 ]
Igal Shilman commented on HBASE-6071:
-------------------------------------
[~qwertymaniac] n/p.
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: Client, IPC/RPC
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Attachments: HBASE-6071.patch, HBASE-6071.v2.patch, HBASE-6071.v3.patch, HBASE-6071.v4.patch, HConnectionManager_HBASE-6071-0.90.0.patch, lease-exception.txt
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "Igal Shilman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igal Shilman updated HBASE-6071:
--------------------------------
Attachment: HBASE-6071.v2.patch
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: client, ipc
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Attachments: HBASE-6071.patch, HBASE-6071.v2.patch, HConnectionManager_HBASE-6071-0.90.0.patch
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283987#comment-13283987 ]
Hadoop QA commented on HBASE-6071:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12529868/HBASE-6071.v2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2008//console
This message is automatically generated.
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: client, ipc
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Attachments: HBASE-6071.patch, HBASE-6071.v2.patch, HConnectionManager_HBASE-6071-0.90.0.patch
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "Igal Shilman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igal Shilman updated HBASE-6071:
--------------------------------
Affects Version/s: 0.92.0
0.94.0
Fix Version/s: (was: 0.90.7)
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: client, ipc
> Affects Versions: 0.90.0, 0.92.0, 0.94.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Attachments: HConnectionManager_HBASE-6071-0.90.0.patch
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460709#comment-13460709 ]
stack commented on HBASE-6071:
------------------------------
How much more log does this patch generate Igal? As I read it, it is logging every retry.
Maybe we should commit this even if it ups the log noise in buckets so we get more conscious about the retrying that is going on mostly silently currently .... we might do something more about it in client?
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: Client, IPC/RPC
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Attachments: HBASE-6071.patch, HBASE-6071.v2.patch, HBASE-6071.v3.patch, HBASE-6071.v4.patch, HConnectionManager_HBASE-6071-0.90.0.patch, lease-exception.txt
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460433#comment-13460433 ]
Hadoop QA commented on HBASE-6071:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12546017/HBASE-6071.v4.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
-1 javadoc. The javadoc tool appears to have generated 139 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestMultiParallel
org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2915//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2915//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2915//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2915//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2915//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2915//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2915//console
This message is automatically generated.
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: Client, IPC/RPC
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Attachments: HBASE-6071.patch, HBASE-6071.v2.patch, HBASE-6071.v3.patch, HBASE-6071.v4.patch, HConnectionManager_HBASE-6071-0.90.0.patch, lease-exception.txt
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "Igal Shilman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igal Shilman updated HBASE-6071:
--------------------------------
Affects Version/s: (was: 0.90.4)
0.90.0
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: client, ipc
> Affects Versions: 0.90.0
> Reporter: Igal Shilman
> Priority: Minor
> Attachments: HConnectionManager_HBASE-6071-0.90.0.patch
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431090#comment-13431090 ]
Hadoop QA commented on HBASE-6071:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12539860/lease-exception.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2534//console
This message is automatically generated.
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: client, ipc
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Attachments: HBASE-6071.patch, HBASE-6071.v2.patch, HBASE-6071.v3.patch, HConnectionManager_HBASE-6071-0.90.0.patch, lease-exception.txt
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "Igal Shilman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283986#comment-13283986 ]
Igal Shilman commented on HBASE-6071:
-------------------------------------
Thanks for commenting, I would like to clarify:
bq. My original intention was using the above debug log to facilitate finding root cause.
Our 0.90.4 production clients are already patched, following your suggestion from the mailing list.
We are still waiting for the original error to occur (it happens infrequently) and when it'll happen I'll report back w/ the details.
bq. It would be nice if debug log is added to 0.90 release you're using and see what we get.
I have also prepared a patch for the 0.90 branch, backporting hbase.client.log.scanner.activity to the ScannerCallable. If it has any value besides debugging our case, I'd be happy to submit it.
bq. getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
I understand that trunk's ScannerCallable has a hbase.client.log.scanner.activity option, that enables logging failures from the scanner's side, yet ServerCallable along w/ its retry facility is being used by others as well, so they are still affected by the issue reported in this JIRA. Therefore, following your initial intention, I'm suggesting the patch for the trunk (+ backport, if approved) that simply logs an exception at each retry.
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: client, ipc
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Attachments: HBASE-6071.patch, HConnectionManager_HBASE-6071-0.90.0.patch
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "Igal Shilman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igal Shilman updated HBASE-6071:
--------------------------------
Fix Version/s: 0.90.7
Labels: client ipc (was: )
Status: Patch Available (was: Open)
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: client, ipc
> Affects Versions: 0.90.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Fix For: 0.90.7
>
> Attachments: HConnectionManager_HBASE-6071-0.90.0.patch
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "Igal Shilman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283285#comment-13283285 ]
Igal Shilman commented on HBASE-6071:
-------------------------------------
[~zhihyu@ebaysf.com], can you please help clarifying core tests score? I went thru the test results and didn't find any failures. Also, browsing around recently submitted patches I see the same findbugs warning count, should I conclude that this is not necessary related to this patch?
Thanks.
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: client, ipc
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Attachments: HBASE-6071.patch, HConnectionManager_HBASE-6071-0.90.0.patch
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460806#comment-13460806 ]
Harsh J commented on HBASE-6071:
--------------------------------
- Maybe we can log it only for SocketTimeoutExceptions as shown in Igal's log?
- Would it be wise of the client to dynamically-increase its timeout factor by a small (configurable) margin, if it receives a socket timeout when waiting for a response, such as in this case? Doesn't help for all sorta issues, but may help those who can enable the small increment feature. (Gets into the way of MTTR if its put into the wrong config files (such as RS's) though).
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: Client, IPC/RPC
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Attachments: HBASE-6071.patch, HBASE-6071.v2.patch, HBASE-6071.v3.patch, HBASE-6071.v4.patch, HConnectionManager_HBASE-6071-0.90.0.patch, lease-exception.txt
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "Igal Shilman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igal Shilman updated HBASE-6071:
--------------------------------
Status: Open (was: Patch Available)
I didn't know that patches has to be submitted against trunk first.
And also, I didn't know that diff's has to be created with --no-prefix
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: client, ipc
> Affects Versions: 0.90.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Fix For: 0.90.7
>
> Attachments: HConnectionManager_HBASE-6071-0.90.0.patch
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460415#comment-13460415 ]
Harsh J commented on HBASE-6071:
--------------------------------
Thanks for addressing my comment Igal, this looks good to me (am not a committer on HBase).
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: Client, IPC/RPC
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Attachments: HBASE-6071.patch, HBASE-6071.v2.patch, HBASE-6071.v3.patch, HBASE-6071.v4.patch, HConnectionManager_HBASE-6071-0.90.0.patch, lease-exception.txt
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "Igal Shilman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igal Shilman updated HBASE-6071:
--------------------------------
Attachment: HBASE-6071.v3.patch
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: client, ipc
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Attachments: HBASE-6071.patch, HBASE-6071.v2.patch, HConnectionManager_HBASE-6071-0.90.0.patch
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "Igal Shilman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igal Shilman updated HBASE-6071:
--------------------------------
Attachment: HConnectionManager_HBASE-6071-0.90.0.patch
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: client, ipc
> Affects Versions: 0.90.4
> Reporter: Igal Shilman
> Priority: Minor
> Attachments: HConnectionManager_HBASE-6071-0.90.0.patch
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "Igal Shilman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igal Shilman updated HBASE-6071:
--------------------------------
Attachment: HBASE-6071.patch
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: client, ipc
> Affects Versions: 0.90.0, 0.92.0, 0.94.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Attachments: HBASE-6071.patch, HConnectionManager_HBASE-6071-0.90.0.patch
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "Igal Shilman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igal Shilman updated HBASE-6071:
--------------------------------
Attachment: lease-exception.txt
We've managed to catch another lease exception, this time with the patched client. Attaching the relevant bits from the logs (client & region server).
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: client, ipc
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Attachments: HBASE-6071.patch, HBASE-6071.v2.patch, HBASE-6071.v3.patch, HConnectionManager_HBASE-6071-0.90.0.patch, lease-exception.txt
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283301#comment-13283301 ]
Zhihong Yu commented on HBASE-6071:
-----------------------------------
I used my script to scan https://builds.apache.org/job/PreCommit-HBASE-Build/1991/console and didn't find hanging test.
{code}
+ String message = String.format("Exception during try #%d (out of %d):",tries+1, numRetries);
+ LOG.debug(message,t);
{code}
nit: space should be inserted between comma and tries, between comma and t.
My original intention was using the above debug log to facilitate finding root cause.
It would be nice if debug log is added to 0.90 release you're using and see what we get.
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: client, ipc
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Attachments: HBASE-6071.patch, HConnectionManager_HBASE-6071-0.90.0.patch
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-6071:
---------------------------------
Fix Version/s: (was: 0.94.2)
(was: 0.96.0)
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: client, ipc
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Attachments: HBASE-6071.patch, HBASE-6071.v2.patch, HBASE-6071.v3.patch, HConnectionManager_HBASE-6071-0.90.0.patch, lease-exception.txt
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283105#comment-13283105 ]
Hadoop QA commented on HBASE-6071:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12529461/HBASE-6071.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 hadoop23. The patch compiles against the hadoop 0.23.x profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 33 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1991//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1991//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1991//console
This message is automatically generated.
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: client, ipc
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Attachments: HBASE-6071.patch, HConnectionManager_HBASE-6071-0.90.0.patch
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "Igal Shilman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igal Shilman updated HBASE-6071:
--------------------------------
Attachment: HBASE-6071.v4.patch
Changing debug level to info.
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: Client, IPC/RPC
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Attachments: HBASE-6071.patch, HBASE-6071.v2.patch, HBASE-6071.v3.patch, HBASE-6071.v4.patch, HConnectionManager_HBASE-6071-0.90.0.patch, lease-exception.txt
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459660#comment-13459660 ]
Harsh J commented on HBASE-6071:
--------------------------------
Nice patch. I'd prefer if we logged this at INFO itself though. This sorta retry is also known to kill remote bulkloads with tons of re-requests presently and we wouldn't know that if we didn't catch it via logs.
Secondly, it is tough on many older versions of Hadoop to enable DEBUG level logs in MR (where this (LE) is often reported from).
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: client, ipc
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Attachments: HBASE-6071.patch, HBASE-6071.v2.patch, HBASE-6071.v3.patch, HConnectionManager_HBASE-6071-0.90.0.patch, lease-exception.txt
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464972#comment-13464972 ]
stack commented on HBASE-6071:
------------------------------
Patch looks fine. I'd change the below to throw an InterruptedIOException:
{code}
+ logAndGiveUp(new IOException("Giving up after tries=" + tries, e), tries, exceptions);
{code}
... but I can do that on commit.
Are you running this change? Does it work for you?
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: Client, IPC/RPC
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Attachments: HBASE-6071.patch, HBASE-6071.v2.patch, HBASE-6071.v3.patch, HBASE-6071.v4.patch, HBASE-6071.v5.patch, HConnectionManager_HBASE-6071-0.90.0.patch, lease-exception.txt
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283302#comment-13283302 ]
Zhihong Yu commented on HBASE-6071:
-----------------------------------
If you look at ScannerCallable.java in trunk, you would see the following:
{code}
public static final String LOG_SCANNER_ACTIVITY = "hbase.client.log.scanner.activity";
...
} catch (IOException e) {
if (logScannerActivity) {
LOG.info("Got exception in fetching from scanner="
+ scannerId, e);
}
{code}
You can backport related code and set hbase.client.log.scanner.activity to true.
This way you would see the exception in log.
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: client, ipc
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Attachments: HBASE-6071.patch, HConnectionManager_HBASE-6071-0.90.0.patch
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13282504#comment-13282504 ]
Hadoop QA commented on HBASE-6071:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12528963/HConnectionManager_HBASE-6071-0.90.0.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1983//console
This message is automatically generated.
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: client, ipc
> Affects Versions: 0.90.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Fix For: 0.90.7
>
> Attachments: HConnectionManager_HBASE-6071-0.90.0.patch
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-6071:
---------------------------------
Fix Version/s: 0.94.2
0.96.0
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: client, ipc
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Fix For: 0.96.0, 0.94.2
>
> Attachments: HBASE-6071.patch, HBASE-6071.v2.patch, HBASE-6071.v3.patch, HConnectionManager_HBASE-6071-0.90.0.patch, lease-exception.txt
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "Igal Shilman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igal Shilman updated HBASE-6071:
--------------------------------
Attachment: (was: HBASE-6071.v3.patch)
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: client, ipc
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Attachments: HBASE-6071.patch, HBASE-6071.v2.patch, HConnectionManager_HBASE-6071-0.90.0.patch
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "Igal Shilman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igal Shilman updated HBASE-6071:
--------------------------------
Attachment: HBASE-6071.v3.patch
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: client, ipc
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Attachments: HBASE-6071.patch, HBASE-6071.v2.patch, HBASE-6071.v3.patch, HConnectionManager_HBASE-6071-0.90.0.patch
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284013#comment-13284013 ]
Zhihong Yu commented on HBASE-6071:
-----------------------------------
Thanks for the explanation, Igal.
I'd be happy to see the output from your patch running in 0.90.4 production.
FYI HBASE-4336 has changed source structure.
{code}
+ String message = String.format("Exception during try #%d (out of %d):", tries+1, numRetries);
{code}
The above line is beyond 100 chars, please wrap the last parameter.
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: client, ipc
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Attachments: HBASE-6071.patch, HBASE-6071.v2.patch, HConnectionManager_HBASE-6071-0.90.0.patch
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6071) getRegionServerWithRetires, should
log unsuccessful attempts and exceptions.
Posted by "Igal Shilman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461129#comment-13461129 ]
Igal Shilman commented on HBASE-6071:
-------------------------------------
bq. How much more log does this patch generate Igal? As I read it, it is logging every retry.
>From what we've seen, most of the calls complete within a single attempt, if a retry occurs then it's pretty much fatal (next attempt is LE), so, in our case, it's up to a single exception being logged.
I guess folks running long lived clients will see more of these logs.
bq. we might do something more about it in client?
Maybe log just the abnormal exits?
I mean: If a call eventually succeeds, then failed retries won't be logged,
otherwise we log all the ThrowableWithExtraContext that were accumulated during previous attempts.
for example, a single iteration of withRetries() might look:
{code:java}
try {
beforeCall();
connect(tries != 0);
return call();
} catch (Throwable t) {
try {
handleFailedAttempt(t, numRetries, tries, exceptions);
} catch (RetriesExhaustedException e) {
throw e;
} catch (IOException e) {
LOG.info("Giving up", new RetriesExhaustedException(numRetries, exceptions));
throw e;
}
} finally {
afterCall();
}
{code}
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: Client, IPC/RPC
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Attachments: HBASE-6071.patch, HBASE-6071.v2.patch, HBASE-6071.v3.patch, HBASE-6071.v4.patch, HConnectionManager_HBASE-6071-0.90.0.patch, lease-exception.txt
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira