You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by charsyam <gi...@git.apache.org> on 2015/07/03 19:17:02 UTC
[GitHub] tajo pull request: TAJO-1672 Removing rest api to create table POS...
GitHub user charsyam opened a pull request:
https://github.com/apache/tajo/pull/623
TAJO-1672 Removing rest api to create table POST /databases/{database-name}/tables interface
Currently, POST /databases/{database-name}
/tables interface is too hard to use. Because it just serialize TableDesc Class. so I think just using query interface is better than create table interface
and for them, changed result of query interface
removing location header, and add response body has query, and ResultCode
and url.(if query is finished directlry, uri isn't)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/charsyam/tajo feature/remove-create-table-rest-api
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/623.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #623
----
commit 2469f3a419592c420a49a611692c7c51309ce52f
Author: clark.kang <cl...@kakao.com>
Date: 2015-07-03T17:01:05Z
remove create table rest api interface
remove tajo-env.sh
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1672 Removing rest api to create table POS...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/623#issuecomment-120055610
+1
Thanks @charsyam
I've just committed it to the master branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1672 Removing rest api to create table POS...
Posted by charsyam <gi...@git.apache.org>.
Github user charsyam commented on the pull request:
https://github.com/apache/tajo/pull/623#issuecomment-118746485
@blrunner I rebased it :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1672 Removing rest api to create table POS...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/623#issuecomment-118746675
Thanks! I'll check it. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1672 Removing rest api to create table POS...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/623#issuecomment-118685436
Hi @charsyam
Thanks for your contribution.
Could you rebase it for the Travis CI build?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1672 Removing rest api to create table POS...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/623
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---