You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/02 16:31:42 UTC
[GitHub] [superset] villebro opened a new pull request #12894: chore: remove SIP-38 feature flag
villebro opened a new pull request #12894:
URL: https://github.com/apache/superset/pull/12894
### SUMMARY
This removes the now redundant SIP-38 feature flag and associated code. The PR should not cause any functional changes, but rather just simplify code.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #12894: chore: remove SIP-38 feature flag
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12894:
URL: https://github.com/apache/superset/pull/12894#issuecomment-771836496
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12894: chore: remove SIP-38 feature flag
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12894:
URL: https://github.com/apache/superset/pull/12894#issuecomment-771777520
# [Codecov](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=h1) Report
> Merging [#12894](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=desc) (63fe77b) into [master](https://codecov.io/gh/apache/superset/commit/9cc38ac1d93a44925d9cd8dcc49fb2a204ef7308?el=desc) (9cc38ac) will **decrease** coverage by `1.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12894 +/- ##
==========================================
- Coverage 63.21% 61.84% -1.37%
==========================================
Files 1025 535 -490
Lines 50291 20045 -30246
Branches 5241 5241
==========================================
- Hits 31790 12397 -19393
+ Misses 18289 7436 -10853
Partials 212 212
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `61.84% <ø> (ø)` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/async\_query\_manager.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvYXN5bmNfcXVlcnlfbWFuYWdlci5weQ==) | | |
| [superset/views/log/views.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | | |
| [superset/reports/notifications/exceptions.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2V4Y2VwdGlvbnMucHk=) | | |
| [...versions/bb51420eaf83\_add\_schema\_to\_table\_model.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9iYjUxNDIwZWFmODNfYWRkX3NjaGVtYV90b190YWJsZV9tb2RlbC5weQ==) | | |
| [superset/migrations/versions/472d2f73dfd4\_.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy80NzJkMmY3M2RmZDRfLnB5) | | |
| [superset/examples/sf\_population\_polygons.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvc2ZfcG9wdWxhdGlvbl9wb2x5Z29ucy5weQ==) | | |
| [...ab3d66c4246e\_add\_cache\_timeout\_to\_druid\_cluster.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hYjNkNjZjNDI0NmVfYWRkX2NhY2hlX3RpbWVvdXRfdG9fZHJ1aWRfY2x1c3Rlci5weQ==) | | |
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | | |
| [superset/db\_engine\_specs/db2.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RiMi5weQ==) | | |
| [...ns/versions/b5998378c225\_add\_certificate\_to\_dbs.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9iNTk5ODM3OGMyMjVfYWRkX2NlcnRpZmljYXRlX3RvX2Ricy5weQ==) | | |
| ... and [473 more](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=footer). Last update [9cc38ac...63fe77b](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12894: chore: remove SIP-38 feature flag
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12894:
URL: https://github.com/apache/superset/pull/12894#issuecomment-771777520
# [Codecov](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=h1) Report
> Merging [#12894](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=desc) (63fe77b) into [master](https://codecov.io/gh/apache/superset/commit/9cc38ac1d93a44925d9cd8dcc49fb2a204ef7308?el=desc) (9cc38ac) will **increase** coverage by `1.81%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12894 +/- ##
==========================================
+ Coverage 63.21% 65.02% +1.81%
==========================================
Files 1025 1024 -1
Lines 50291 48702 -1589
Branches 5241 5241
==========================================
- Hits 31790 31669 -121
+ Misses 18289 16821 -1468
Partials 212 212
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `61.84% <ø> (ø)` | |
| python | `67.25% <100.00%> (+3.13%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <ø> (ø)` | |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.53% <100.00%> (+1.75%)` | :arrow_up: |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.14% <100.00%> (-0.07%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.55% <100.00%> (-0.04%)` | :arrow_down: |
| [superset/models/slice.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `85.87% <100.00%> (+0.40%)` | :arrow_up: |
| [superset/views/utils.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `83.39% <100.00%> (+0.19%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-7.15%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=footer). Last update [9cc38ac...63fe77b](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12894: chore: remove SIP-38 feature flag
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12894:
URL: https://github.com/apache/superset/pull/12894#issuecomment-771777520
# [Codecov](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=h1) Report
> Merging [#12894](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=desc) (63fe77b) into [master](https://codecov.io/gh/apache/superset/commit/9cc38ac1d93a44925d9cd8dcc49fb2a204ef7308?el=desc) (9cc38ac) will **increase** coverage by `1.79%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12894 +/- ##
==========================================
+ Coverage 63.21% 65.00% +1.79%
==========================================
Files 1025 1024 -1
Lines 50291 48702 -1589
Branches 5241 5241
==========================================
- Hits 31790 31660 -130
+ Misses 18289 16830 -1459
Partials 212 212
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `61.84% <ø> (ø)` | |
| python | `67.21% <100.00%> (+3.10%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <ø> (ø)` | |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.53% <100.00%> (+1.75%)` | :arrow_up: |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.14% <100.00%> (-0.07%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.28% <100.00%> (-0.30%)` | :arrow_down: |
| [superset/models/slice.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `85.87% <100.00%> (+0.40%)` | :arrow_up: |
| [superset/views/utils.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `83.39% <100.00%> (+0.19%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-7.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=footer). Last update [9cc38ac...63fe77b](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #12894: chore: remove SIP-38 feature flag
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12894:
URL: https://github.com/apache/superset/pull/12894#issuecomment-771855471
Yeah, I also feel the FF is a little confusing when I worked on this area. We should probably elect for bigger if branches more often other than `is_ff_enabled` everywhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12894: chore: remove SIP-38 feature flag
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12894:
URL: https://github.com/apache/superset/pull/12894#issuecomment-771777520
# [Codecov](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=h1) Report
> Merging [#12894](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=desc) (e2b1794) into [master](https://codecov.io/gh/apache/superset/commit/9cc38ac1d93a44925d9cd8dcc49fb2a204ef7308?el=desc) (9cc38ac) will **increase** coverage by `1.60%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12894 +/- ##
==========================================
+ Coverage 63.21% 64.81% +1.60%
==========================================
Files 1025 1024 -1
Lines 50291 48702 -1589
Branches 5241 5241
==========================================
- Hits 31790 31566 -224
+ Misses 18289 16924 -1365
Partials 212 212
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `61.84% <ø> (ø)` | |
| python | `66.89% <100.00%> (+2.77%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <ø> (ø)` | |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.53% <100.00%> (+1.75%)` | :arrow_up: |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.14% <100.00%> (-0.07%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.63% <100.00%> (-0.96%)` | :arrow_down: |
| [superset/models/slice.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `85.87% <100.00%> (+0.40%)` | :arrow_up: |
| [superset/views/utils.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `83.39% <100.00%> (+0.19%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| ... and [17 more](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=footer). Last update [9cc38ac...e2b1794](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12894: chore: remove SIP-38 feature flag
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12894:
URL: https://github.com/apache/superset/pull/12894#issuecomment-771777520
# [Codecov](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=h1) Report
> Merging [#12894](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=desc) (e2b1794) into [master](https://codecov.io/gh/apache/superset/commit/9cc38ac1d93a44925d9cd8dcc49fb2a204ef7308?el=desc) (9cc38ac) will **increase** coverage by `1.59%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12894 +/- ##
==========================================
+ Coverage 63.21% 64.81% +1.59%
==========================================
Files 1025 1024 -1
Lines 50291 48694 -1597
Branches 5241 5241
==========================================
- Hits 31790 31559 -231
+ Misses 18289 16923 -1366
Partials 212 212
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `61.84% <ø> (ø)` | |
| python | `66.88% <100.00%> (+2.76%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <ø> (ø)` | |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.53% <100.00%> (+1.75%)` | :arrow_up: |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.14% <100.00%> (-0.07%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.61% <100.00%> (-0.97%)` | :arrow_down: |
| [superset/models/slice.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `85.87% <100.00%> (+0.40%)` | :arrow_up: |
| [superset/views/utils.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `83.39% <100.00%> (+0.19%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| ... and [23 more](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=footer). Last update [9cc38ac...e2b1794](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12894: chore: remove SIP-38 feature flag
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12894:
URL: https://github.com/apache/superset/pull/12894#issuecomment-771777520
# [Codecov](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=h1) Report
> Merging [#12894](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=desc) (63fe77b) into [master](https://codecov.io/gh/apache/superset/commit/9cc38ac1d93a44925d9cd8dcc49fb2a204ef7308?el=desc) (9cc38ac) will **increase** coverage by `1.75%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12894 +/- ##
==========================================
+ Coverage 63.21% 64.96% +1.75%
==========================================
Files 1025 1024 -1
Lines 50291 48694 -1597
Branches 5241 5241
==========================================
- Hits 31790 31636 -154
+ Misses 18289 16846 -1443
Partials 212 212
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `61.84% <ø> (ø)` | |
| python | `67.15% <100.00%> (+3.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <ø> (ø)` | |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.53% <100.00%> (+1.75%)` | :arrow_up: |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.14% <100.00%> (-0.07%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.61% <100.00%> (-0.97%)` | :arrow_down: |
| [superset/models/slice.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `85.87% <100.00%> (+0.40%)` | :arrow_up: |
| [superset/views/utils.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `83.39% <100.00%> (+0.19%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-7.15%)` | :arrow_down: |
| ... and [15 more](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=footer). Last update [9cc38ac...63fe77b](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #12894: chore: remove SIP-38 feature flag
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #12894:
URL: https://github.com/apache/superset/pull/12894
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #12894: chore: remove SIP-38 feature flag
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12894:
URL: https://github.com/apache/superset/pull/12894#issuecomment-771836496
Did we decide not to deprecate `groupby` anymore?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #12894: chore: remove SIP-38 feature flag
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #12894:
URL: https://github.com/apache/superset/pull/12894#issuecomment-771838404
We will, we're just cleaning out this FF as this was mostly an experiment to make sure it works. I'd prefer to redesign this properly (the approach taken here was not optimal).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12894: chore: remove SIP-38 feature flag
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12894:
URL: https://github.com/apache/superset/pull/12894#issuecomment-771777520
# [Codecov](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=h1) Report
> Merging [#12894](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=desc) (e2b1794) into [master](https://codecov.io/gh/apache/superset/commit/9cc38ac1d93a44925d9cd8dcc49fb2a204ef7308?el=desc) (9cc38ac) will **increase** coverage by `3.67%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12894 +/- ##
==========================================
+ Coverage 63.21% 66.88% +3.67%
==========================================
Files 1025 489 -536
Lines 50291 28649 -21642
Branches 5241 0 -5241
==========================================
- Hits 31790 19162 -12628
+ Misses 18289 9487 -8802
+ Partials 212 0 -212
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `66.88% <100.00%> (+2.76%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <ø> (ø)` | |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.53% <100.00%> (+1.75%)` | :arrow_up: |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.14% <100.00%> (-0.07%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.61% <100.00%> (-0.97%)` | :arrow_down: |
| [superset/models/slice.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `85.87% <100.00%> (+0.40%)` | :arrow_up: |
| [superset/views/utils.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `83.39% <100.00%> (+0.19%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| ... and [558 more](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=footer). Last update [9cc38ac...e2b1794](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12894: chore: remove SIP-38 feature flag
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12894:
URL: https://github.com/apache/superset/pull/12894#issuecomment-771777520
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #12894: chore: remove SIP-38 feature flag
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #12894:
URL: https://github.com/apache/superset/pull/12894#issuecomment-771838404
We will, we're just cleaning out this FF as this was mostly an experiment to make sure it works. I'd prefer to redesign this properly (the approach taken here was not optimal).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12894: chore: remove SIP-38 feature flag
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12894:
URL: https://github.com/apache/superset/pull/12894#issuecomment-771777520
# [Codecov](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=h1) Report
> Merging [#12894](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=desc) (63fe77b) into [master](https://codecov.io/gh/apache/superset/commit/9cc38ac1d93a44925d9cd8dcc49fb2a204ef7308?el=desc) (9cc38ac) will **decrease** coverage by `1.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12894 +/- ##
==========================================
- Coverage 63.21% 61.84% -1.37%
==========================================
Files 1025 535 -490
Lines 50291 20045 -30246
Branches 5241 5241
==========================================
- Hits 31790 12397 -19393
+ Misses 18289 7436 -10853
Partials 212 212
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `61.84% <ø> (ø)` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/async\_query\_manager.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvYXN5bmNfcXVlcnlfbWFuYWdlci5weQ==) | | |
| [superset/views/log/views.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | | |
| [superset/reports/notifications/exceptions.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2V4Y2VwdGlvbnMucHk=) | | |
| [...versions/bb51420eaf83\_add\_schema\_to\_table\_model.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9iYjUxNDIwZWFmODNfYWRkX3NjaGVtYV90b190YWJsZV9tb2RlbC5weQ==) | | |
| [superset/migrations/versions/472d2f73dfd4\_.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy80NzJkMmY3M2RmZDRfLnB5) | | |
| [superset/examples/sf\_population\_polygons.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvc2ZfcG9wdWxhdGlvbl9wb2x5Z29ucy5weQ==) | | |
| [...ab3d66c4246e\_add\_cache\_timeout\_to\_druid\_cluster.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hYjNkNjZjNDI0NmVfYWRkX2NhY2hlX3RpbWVvdXRfdG9fZHJ1aWRfY2x1c3Rlci5weQ==) | | |
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | | |
| [superset/db\_engine\_specs/db2.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RiMi5weQ==) | | |
| [...ns/versions/b5998378c225\_add\_certificate\_to\_dbs.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9iNTk5ODM3OGMyMjVfYWRkX2NlcnRpZmljYXRlX3RvX2Ricy5weQ==) | | |
| ... and [473 more](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=footer). Last update [9cc38ac...63fe77b](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org