You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "vikrambohra (via GitHub)" <gi...@apache.org> on 2023/06/17 05:21:26 UTC
[GitHub] [gobblin] vikrambohra opened a new pull request, #3706: [GOBBLIN-1845] Changes parallelstream to stream in DatasetsFinderFilt…
vikrambohra opened a new pull request, #3706:
URL: https://github.com/apache/gobblin/pull/3706
…eringDecorator to avoid classloader issues in spark
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-1845] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1845
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
DatasetsFinderFilteringDecorator uses parallel stream on datasets to filter them on predicates. When this code runs in spark, system class loader gets used to pickup hive jar instead of the current conext class loader which leads to ClassNotFound issues
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Small change that should already be covered in unit tests
Also, tested this on the hadoop cluster at linkedin
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] ZihanLi58 merged pull request #3706: [GOBBLIN-1845] Changes parallelstream to stream in DatasetsFinderFilt…
Posted by "ZihanLi58 (via GitHub)" <gi...@apache.org>.
ZihanLi58 merged PR #3706:
URL: https://github.com/apache/gobblin/pull/3706
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-commenter commented on pull request #3706: [GOBBLIN-1845] Changes parallelstream to stream in DatasetsFinderFilt…
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3706:
URL: https://github.com/apache/gobblin/pull/3706#issuecomment-1595868617
## [Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3706?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#3706](https://app.codecov.io/gh/apache/gobblin/pull/3706?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a5a5924) into [master](https://app.codecov.io/gh/apache/gobblin/commit/ee17b1576759c0669bf7bc46c9faf6868544ceb9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ee17b15) will **decrease** coverage by `2.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3706 +/- ##
============================================
- Coverage 46.83% 44.84% -2.00%
+ Complexity 10797 2102 -8695
============================================
Files 2141 411 -1730
Lines 84410 17734 -66676
Branches 9383 2162 -7221
============================================
- Hits 39533 7952 -31581
+ Misses 41272 8922 -32350
+ Partials 3605 860 -2745
```
[see 1734 files with indirect coverage changes](https://app.codecov.io/gh/apache/gobblin/pull/3706/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] mridulm commented on pull request #3706: [GOBBLIN-1845] Changes parallelstream to stream in DatasetsFinderFilt…
Posted by "mridulm (via GitHub)" <gi...@apache.org>.
mridulm commented on PR #3706:
URL: https://github.com/apache/gobblin/pull/3706#issuecomment-1596241791
This will work, but is performance a concern ?
If yes, setting the thread's context classloader to spark classloader should fix that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org