You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ranger.apache.org by ab...@apache.org on 2023/02/04 19:25:29 UTC

[ranger] branch master updated: RANGER-4069: Add performance tracing instrumentation to Tag Enricher

This is an automated email from the ASF dual-hosted git repository.

abhay pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ranger.git


The following commit(s) were added to refs/heads/master by this push:
     new f9bfc90fb RANGER-4069: Add performance tracing instrumentation to Tag Enricher
f9bfc90fb is described below

commit f9bfc90fb53f06a752f4190e20be337ed70ec657
Author: Abhay Kulkarni <ab...@apache.org>
AuthorDate: Sat Feb 4 11:25:16 2023 -0800

    RANGER-4069: Add performance tracing instrumentation to Tag Enricher
---
 .../apache/ranger/plugin/contextenricher/RangerTagEnricher.java  | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java b/agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java
index da06e4161..bbea4cec6 100644
--- a/agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java
+++ b/agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java
@@ -75,6 +75,7 @@ public class RangerTagEnricher extends RangerAbstractContextEnricher {
 	private static final Logger PERF_CONTEXTENRICHER_INIT_LOG = RangerPerfTracer.getPerfLogger("contextenricher.init");
 	private static final Logger PERF_TRIE_OP_LOG              = RangerPerfTracer.getPerfLogger("resourcetrie.retrieval");
 	private static final Logger PERF_SET_SERVICETAGS_LOG      = RangerPerfTracer.getPerfLogger("tagenricher.setservicetags");
+	private static final Logger PERF_SERVICETAGS_RETRIEVAL_LOG = RangerPerfTracer.getPerfLogger("tagenricher.tags.retrieval");
 
 
 	private static final String TAG_REFRESHER_POLLINGINTERVAL_OPTION = "tagRefresherPollingInterval";
@@ -665,6 +666,12 @@ public class RangerTagEnricher extends RangerAbstractContextEnricher {
 
 		RangerAccessResource resource = request.getResource();
 
+		RangerPerfTracer perf = null;
+
+		if (RangerPerfTracer.isPerfTraceEnabled(PERF_SERVICETAGS_RETRIEVAL_LOG)) {
+			perf = RangerPerfTracer.getPerfTracer(PERF_SERVICETAGS_RETRIEVAL_LOG, "RangerTagEnricher.findMatchingTags=" + resource.getAsString() + ")");
+		}
+
 		if ((resource == null || resource.getKeys() == null || resource.getKeys().isEmpty()) && request.isAccessTypeAny()) {
 			ret = enrichedServiceTags.getTagsForEmptyResourceAndAnyAccess();
 		} else {
@@ -698,6 +705,8 @@ public class RangerTagEnricher extends RangerAbstractContextEnricher {
 			}
 		}
 
+		RangerPerfTracer.logAlways(perf);
+
 		if (CollectionUtils.isEmpty(ret)) {
 			if (LOG.isDebugEnabled()) {
 				LOG.debug("RangerTagEnricher.findMatchingTags(" + resource + ") - No tags Found ");