You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ag...@apache.org on 2014/07/14 20:27:03 UTC
android commit: Mark PluginEntry fields as final
Repository: cordova-android
Updated Branches:
refs/heads/4.0.x e2b3f76a1 -> 6f301576e
Mark PluginEntry fields as final
Makes the intention of the class more clear, and the public fields less
bad.
Project: http://git-wip-us.apache.org/repos/asf/cordova-android/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-android/commit/6f301576
Tree: http://git-wip-us.apache.org/repos/asf/cordova-android/tree/6f301576
Diff: http://git-wip-us.apache.org/repos/asf/cordova-android/diff/6f301576
Branch: refs/heads/4.0.x
Commit: 6f301576ebbf2a631c7f36af3cc97d482a2d0d3d
Parents: e2b3f76
Author: Andrew Grieve <ag...@chromium.org>
Authored: Mon Jul 14 14:26:21 2014 -0400
Committer: Andrew Grieve <ag...@chromium.org>
Committed: Mon Jul 14 14:26:21 2014 -0400
----------------------------------------------------------------------
framework/src/org/apache/cordova/PluginEntry.java | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-android/blob/6f301576/framework/src/org/apache/cordova/PluginEntry.java
----------------------------------------------------------------------
diff --git a/framework/src/org/apache/cordova/PluginEntry.java b/framework/src/org/apache/cordova/PluginEntry.java
index 9782825..c56c453 100755
--- a/framework/src/org/apache/cordova/PluginEntry.java
+++ b/framework/src/org/apache/cordova/PluginEntry.java
@@ -23,27 +23,27 @@ import org.apache.cordova.CordovaPlugin;
/**
* This class represents a service entry object.
*/
-public class PluginEntry {
+public final class PluginEntry {
/**
* The name of the service that this plugin implements
*/
- public String service;
+ public final String service;
/**
* The plugin class name that implements the service.
*/
- public String pluginClass;
+ public final String pluginClass;
/**
* The pre-instantiated plugin to use for this entry.
*/
- public CordovaPlugin plugin;
+ public final CordovaPlugin plugin;
/**
* Flag that indicates the plugin object should be created when PluginManager is initialized.
*/
- public boolean onload;
+ public final boolean onload;
/**
* Constructs with a CordovaPlugin already instantiated.