You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/07/14 09:15:56 UTC

[GitHub] [zookeeper] Technoboy- opened a new pull request #1401: ZOOKEEPER-3888: Add source and target version for compile plugin

Technoboy- opened a new pull request #1401:
URL: https://github.com/apache/zookeeper/pull/1401


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] Technoboy- commented on pull request #1401: ZOOKEEPER-3888: Add source and target version for compile plugin

Posted by GitBox <gi...@apache.org>.

Technoboy- commented on pull request #1401:
URL: https://github.com/apache/zookeeper/pull/1401#issuecomment-663081815


   > > Yes, you are right. This is a global config. Different project should have it's own config.
   > 
   > I am not certain I understand this response. I _think_ you are trying to suggest that the child module should be configured explicitly, separate from the parent POM. If so, that undermines the whole point of having a parent POM to standardize build tooling across the modules.
   
   I am sorry for this, I miss the properties configs in pom.  Thanks for kindly giving the response.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] Technoboy- commented on pull request #1401: ZOOKEEPER-3888: Add source and target version for compile plugin

Posted by GitBox <gi...@apache.org>.

Technoboy- commented on pull request #1401:
URL: https://github.com/apache/zookeeper/pull/1401#issuecomment-662786657


   > it works for me too... @Technoboy- what is your maven version? (I used 3.6.3)
   
   3.6.0
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] symat commented on pull request #1401: ZOOKEEPER-3888: Add source and target version for compile plugin

Posted by GitBox <gi...@apache.org>.

symat commented on pull request #1401:
URL: https://github.com/apache/zookeeper/pull/1401#issuecomment-660961528


   it works for me too... @Technoboy-  what is your maven version? (I used 3.6.3)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] ctubbsii edited a comment on pull request #1401: ZOOKEEPER-3888: Add source and target version for compile plugin

Posted by GitBox <gi...@apache.org>.

ctubbsii edited a comment on pull request #1401:
URL: https://github.com/apache/zookeeper/pull/1401#issuecomment-662811359

> It can not compile due to using jdk1.6 by default. So we would better to specify the version

I agree the version should be specified. However, the version is *already* specified. You are suggesting adding a *second* specification, which is redundant and makes it harder to keep it consistent throughout the project's multiple modules.

The version is currently specified as properties in the parent POM, where it should be (see [this](https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-source-and-target.html) and [this](https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#source) and [this](https://maven.apache.org/pom.html#Inheritance)).

I'm not sure why yours is failing to build. Are you triggering the build in the child module's directory, or from the root, where the parent POM is located? You should be triggering the build at the root. Also, make sure you aren't specifying `maven.compiler.source` and `maven.compiler.target` anywhere else in your environment such as on the command line or in a custom profile in your `~/.m2/settings.xml` or the super-POM in your Maven installation (which would be a non-standard install, but anything is possible, I suppose).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] Technoboy- commented on pull request #1401: ZOOKEEPER-3888: Add source and target version for compile plugin

Posted by GitBox <gi...@apache.org>.

Technoboy- commented on pull request #1401:
URL: https://github.com/apache/zookeeper/pull/1401#issuecomment-662824138


   > > It can not compile due to using jdk1.6 by default. So we would better to specify the version
   > 
   > I agree the version should be specified. However, the version is _already_ specified. You are suggesting adding a _second_ specification, which is redundant and makes it harder to keep it consistent throughout the project's multiple modules.
   > 
   > The version is currently specified as properties in the parent POM, where it should be (see [this](https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-source-and-target.html) and [this](https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#source) and [this](https://maven.apache.org/pom.html#Inheritance)).
   > 
   > I'm not sure why yours is failing to build. Are you triggering the build in the child module's directory, or from the root, where the parent POM is located? You should be triggering the build at the root. Also, make sure you aren't specifying `maven.compiler.source` and `maven.compiler.target` anywhere else in your environment such as on the command line or in a custom profile in your `~/.m2/settings.xml` or the super-POM in your Maven installation (which would be a non-standard install, but anything is possible, I suppose).
   
   Yes, you are right. This is a global config. Different project should have it's own config.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] ctubbsii commented on pull request #1401: ZOOKEEPER-3888: Add source and target version for compile plugin

Posted by GitBox <gi...@apache.org>.

ctubbsii commented on pull request #1401:
URL: https://github.com/apache/zookeeper/pull/1401#issuecomment-659371621


   > > This is unnecessary. This is already handled with the properties `maven.compiler.source` and `maven.compiler.target`. Setting them here is redundant, and makes it hard to change later (because you'd have to change in multiple places).
   > > I advise closing this PR and NOT applying the proposed changes.
   > 
   > Can you compile from the master branch without this change ?
   
   Yes. It compiles perfectly.
   I skipped the tests, because my system is too busy to run those right now, so the command I used was: `mvn clean verify -DskipTests -DskipITs`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] Technoboy- closed pull request #1401: ZOOKEEPER-3888: Add source and target version for compile plugin

Posted by GitBox <gi...@apache.org>.

Technoboy- closed pull request #1401:
URL: https://github.com/apache/zookeeper/pull/1401


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] Technoboy- closed pull request #1401: ZOOKEEPER-3888: Add source and target version for compile plugin

Posted by GitBox <gi...@apache.org>.

Technoboy- closed pull request #1401:
URL: https://github.com/apache/zookeeper/pull/1401


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] ctubbsii commented on pull request #1401: ZOOKEEPER-3888: Add source and target version for compile plugin

Posted by GitBox <gi...@apache.org>.

ctubbsii commented on pull request #1401:
URL: https://github.com/apache/zookeeper/pull/1401#issuecomment-663051235


   > Yes, you are right. This is a global config. Different project should have it's own config.
   
   I am not certain I understand this response. I *think* you are trying to suggest that the child module should be configured explicitly, separate from the parent POM. If so, that undermines the whole point of having a parent POM to standardize build tooling across the modules.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] Technoboy- commented on pull request #1401: ZOOKEEPER-3888: Add source and target version for compile plugin

Posted by GitBox <gi...@apache.org>.

Technoboy- commented on pull request #1401:
URL: https://github.com/apache/zookeeper/pull/1401#issuecomment-662786858


   > > > This is unnecessary. This is already handled with the properties `maven.compiler.source` and `maven.compiler.target`. Setting them here is redundant, and makes it hard to change later (because you'd have to change in multiple places).
   > > > I advise closing this PR and NOT applying the proposed changes.
   > > 
   > > 
   > > Can you compile from the master branch without this change ?
   > 
   > Yes. It compiles perfectly.
   > I skipped the tests, because my system is too busy to run those right now, so the command I used was: `mvn clean verify -DskipTests -DskipITs`
   
   It can not compile due to using jdk1.6 by default.  So we would better to specify the version


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] ctubbsii commented on pull request #1401: ZOOKEEPER-3888: Add source and target version for compile plugin

Posted by GitBox <gi...@apache.org>.

ctubbsii commented on pull request #1401:
URL: https://github.com/apache/zookeeper/pull/1401#issuecomment-662811359

> It can not compile due to using jdk1.6 by default. So we would better to specify the version

I'm not sure why yours is failing to build. Are you triggering the build in the child module's directory, or from the root, where the parent POM is located? You should be triggering the build at the root, and you aren't specifying `maven.compiler.source` and `maven.compiler.target` anywhere else in your environment such as on the command line or in a custom profile in your `~/.m2/settings.xml` or the super-POM in your Maven installation (which would be a non-standard install, but anything is possible, I suppose).

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] Technoboy- commented on pull request #1401: ZOOKEEPER-3888: Add source and target version for compile plugin

Posted by GitBox <gi...@apache.org>.

Technoboy- commented on pull request #1401:
URL: https://github.com/apache/zookeeper/pull/1401#issuecomment-659193631


   > This is unnecessary. This is already handled with the properties `maven.compiler.source` and `maven.compiler.target`. Setting them here is redundant, and makes it hard to change later (because you'd have to change in multiple places).
   > 
   > I advise closing this PR and NOT applying the proposed changes.
   
   Can you compile from the master branch without this change ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org