[jira] [Commented] (CAMEL-8421) Add minimum age option to readLock=changed

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-8421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14343170#comment-14343170 ] 

ASF GitHub Bot commented on CAMEL-8421:
---------------------------------------

GitHub user yuruki opened a pull request:

    https://github.com/apache/camel/pull/414

    CAMEL-8421 Add minimum age option to readLock=changed

    https://issues.apache.org/jira/browse/CAMEL-8421
    
    Unit tests for File component run fine, but for some reason FTP unit tests all fail (not just mine).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yuruki/camel readlock-olderthan

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/414.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #414
    
----
commit 56383baf76969ddd432429805f51b7cab751d610
Author: Jyrki Ruuskanen <yu...@kotikone.fi>
Date:   2015-02-27T20:30:43Z

    Added readLockMinAge parameter to file, camel-ftp components

----


> Add minimum age option to readLock=changed
> ------------------------------------------
>
>                 Key: CAMEL-8421
>                 URL: https://issues.apache.org/jira/browse/CAMEL-8421
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core, camel-ftp
>            Reporter: Jyrki Ruuskanen
>            Priority: Minor
>
> I'm a fan of noop=true in file consumers since it means I don't have to worry about how many readers I have and where. But eventually I came across a scenario where current features are not sufficient.
> Let's say we have a source system which writes files with name <timestamp>_something.xml, and it won't use temp files or .done marker files or anything like that. We want to get the latest file as soon as it's created. Consider the following route:
> {code}
> from("file:////somewhere/data?noop=true&include=.*_something[.]xml&readLock=changed&sortBy=file:name")
> 	.aggregate(constant(true), new UseLatestAggregationStrategy()).completionFromBatchConsumer()
> 		.to("amq:topic:something");
> {code}
> When this route is started it will go through the files in order and get the last one. Then it will wait for new files. This works fine as long as the writer is not "slow".
> Now, we had cases of incomplete files being read and I was requested to not to read the file before it is 10 minutes old, just in case. If I increase readLockCheckInterval to 10 minutes getting to the latest file at route startup will take close to forever. The current readLock=changed implementation always sleeps for at least one readLockCheckInterval per file.
> If we had readLockMinAge option to define the minimum age for the target file the consumer could acquire readLock on the first poll and breeze through the files until too young a file is reached.
> The route below would poll a file every 500ms (default poll delay), while the current readLock=changed would take 1500ms (default poll delay + default readLockCheckInterval) per file. Consumer goes through the files until it hits the end and gets the last one as soon as it becomes old enough.
> {code}
> from("file:////somewhere/data?noop=true&include=.*_something[.]xml&readLock=changed&readLockMinAge=600000&sortBy=file:name")
> 	.aggregate(constant(true), new UseLatestAggregationStrategy()).completionFromBatchConsumer()
> 		.to("amq:topic:something");
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)