You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/08/27 09:09:51 UTC

[GitHub] [shardingsphere] terrymanu opened a new pull request #12055: Refactor SQLParserEngineAdviceTest

terrymanu opened a new pull request #12055:
URL: https://github.com/apache/shardingsphere/pull/12055


   Changes proposed in this pull request:
   - avoid use package in codes, move them to import
   - One method do one assertion only
   - Extract duplicated codes in one method
   
   And some changes from #12051
   Changes proposed in this pull request:
   - change `Collections.EMPTY_LIST` to `Collections.emptyList()`, just keep consist with existed codes
   - Remove SuppressWarnings of `OptionalGetWithoutIsPresent`, should check optional.isPresent at assertion
   - Remove useless SuppressWarnings of `unchecked`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] menghaoranss merged pull request #12055: Refactor SQLParserEngineAdviceTest

Posted by GitBox <gi...@apache.org>.

menghaoranss merged pull request #12055:
URL: https://github.com/apache/shardingsphere/pull/12055


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org