[GitHub] flink pull request: [FLINK-2399] Version checks for Job Manager an...

[fhueske <gi...@git.apache.org>]

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/945#discussion_r39265532
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobSubmitTest.java ---
    @@ -192,4 +193,78 @@ public void initializeOnMaster(ClassLoader loader) throws Exception {
     			fail(e.getMessage());
     		}
     	}
    +
    +	/**
    +	 * Verifies failure when the client version is lower than supported.
    +	 */
    +	@Test
    --- End diff --
    
    You can implement the test with `@Test(expected=JobSubmissionException.class)` which checks that the correct exception is produced.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---