You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2022/11/17 12:57:12 UTC
[commons-bcel] 01/02: Add logging
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-bcel.git
commit a70d431319b207cdd55823843dcef0efc84c85e9
Author: Gary David Gregory (Code signing key) <gg...@apache.org>
AuthorDate: Thu Nov 17 07:56:51 2022 -0500
Add logging
---
.../bcel/verifier/VerifyJavaHomesTestCase.java | 35 ++++++++++------------
1 file changed, 15 insertions(+), 20 deletions(-)
diff --git a/src/test/java/org/apache/bcel/verifier/VerifyJavaHomesTestCase.java b/src/test/java/org/apache/bcel/verifier/VerifyJavaHomesTestCase.java
index 5b8e3cdb..f08ed4d5 100644
--- a/src/test/java/org/apache/bcel/verifier/VerifyJavaHomesTestCase.java
+++ b/src/test/java/org/apache/bcel/verifier/VerifyJavaHomesTestCase.java
@@ -17,6 +17,8 @@
package org.apache.bcel.verifier;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.MethodSource;
@@ -25,22 +27,11 @@ public class VerifyJavaHomesTestCase extends AbstractVerifierTestCase {
static int count;
+ boolean logStep = Boolean.getBoolean("BCEL.logStep");
+
/**
* Eventually runs out of memory? Super now calls VerifierFactory.clear();
*
- * <pre>
- 164800................................................................................
- 165600...........Exception in thread "fork-1-event-thread" .java.lang.OutOfMemoryError: Java heap space
- Exception in thread "fork-1-event-thread" java.lang.OutOfMemoryError: Java heap space
- at java.lang.AbstractStringBuilder.<init>(AbstractStringBuilder.java:68)
- at java.lang.StringBuilder.<init>(StringBuilder.java:106)
- at org.apache.maven.surefire.api.stream.AbstractStreamDecoder.toString(AbstractStreamDecoder.java:364)
- at org.apache.maven.surefire.api.stream.AbstractStreamDecoder.readString(AbstractStreamDecoder.java:336)
- at org.apache.maven.surefire.api.stream.AbstractStreamDecoder.readString(AbstractStreamDecoder.java:196)
- at org.apache.maven.surefire.stream.EventDecoder.decode(EventDecoder.java:176)
- at org.apache.maven.plugin.surefire.extensions.EventConsumerThread.run(EventConsumerThread.java:73)
- * </pre>
- *
* @param name
* @throws ClassNotFoundException
*/
@@ -52,15 +43,19 @@ public class VerifyJavaHomesTestCase extends AbstractVerifierTestCase {
// System.out.println(jarEntry.getName());
// Skip $ classes for now
count++;
- if (count % 10 == 0) {
- System.out.print('.');
- }
- if (count % 800 == 0) {
- System.out.println();
- System.out.print(count);
+ if (logStep) {
+ System.out.printf("%,d %s%n", count, name);
+ } else {
+ if (count % 10 == 0) {
+ System.out.print('.');
+ }
+ if (count % 800 == 0) {
+ System.out.println();
+ System.out.print(count);
+ }
}
if (!name.contains("$")) {
- doAllPasses(name);
+ assertTrue(doAllPasses(name));
}
}