[GitHub] [incubator-inlong] baomingyu commented on a change in pull request #2493: [INLONG-2483] Manager provide metadata interface to Dataproxy, and Dataproxy dynamically get metadata and MQ config from Manager.

[GitBox <gi...@apache.org>]

baomingyu commented on a change in pull request #2493:
URL: https://github.com/apache/incubator-inlong/pull/2493#discussion_r807456183



##########
File path: inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/config/ConfigManager.java
##########
@@ -244,10 +270,13 @@ private void checkLocalFile() {
             }
         }
 
-        private boolean checkWithManager(String host) {
+        private boolean checkWithManager(String host, String proxyClusterName) {
             HttpGet httpGet = null;
             try {
-                String url = "http://" + host + "/api/inlong/manager/openapi/dataproxy/getConfig";
+                if (proxyClusterName == null) {

Review comment:
       use StringUtils.isEmpty()

##########
File path: inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/sink/PulsarSink.java
##########
@@ -202,14 +180,14 @@ public Long load(String key) {
         /*
          * stat pulsar performance
          */
-        logger.info("PulsarPerformanceTask!!!!!!");
+        System.out.println("pulsarPerformanceTask!!!!!!");

Review comment:
       why use system.out.println way instead of logger ?

##########
File path: inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/config/ConfigManager.java
##########
@@ -53,6 +54,8 @@
             new PropertiesConfigHolder("common.properties");
     private final PropertiesConfigHolder topicConfig =
             new PropertiesConfigHolder("topics.properties");
+    private final MxPropertiesHolder pulsarUrl2token =

Review comment:
       why use MxProoertiesHolder




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org