You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "FlyingZC (via GitHub)" <gi...@apache.org> on 2023/07/13 08:14:02 UTC

[GitHub] [shardingsphere] FlyingZC opened a new issue, #27143: Support parsing Oracle EXPLAIN PLAN sql

FlyingZC opened a new issue, #27143:
URL: https://github.com/apache/shardingsphere/issues/27143

   # Background
   Hi community,
   This issue is for #26878.
   
   ShardingSphere parser engine helps users parse a SQL to get the AST (Abstract Syntax Tree) and visit this tree to get SQLStatement (Java Object). Currently, we are planning to enhance the support for Oracle SQL parsing in ShardingSphere.
   
   More details:
   https://shardingsphere.apache.org/document/current/en/reference/sharding/parse/
   
   # Task
   This issue is to support more oracle sql parse, as follows:
   ```sql
   EXPLAIN PLAN 
     SET statement_id = 'ex_plan2' FOR
   SELECT last_name FROM employees
    WHERE last_name LIKE 'Pe%';
   
   SELECT PLAN_TABLE_OUTPUT 
     FROM TABLE(DBMS_XPLAN.DISPLAY(NULL, 'ex_plan2','BASIC'));
   ```
   
   ```sql
   EXPLAIN PLAN FOR
   ```
   
   ```sql
   EXPLAIN PLAN FOR
     SELECT *
     FROM   sh.customers
     WHERE  cust_city='Los Angeles'
     AND    cust_state_province='CA';
   ```
   
   ```sql
   EXPLAIN PLAN FOR
     SELECT * FROM sales 
        WHERE time_id BETWEEN :h AND '01-OCT-2000';
   ```
   
   ```sql
   EXPLAIN PLAN FOR
     SELECT po.reference, li.*
       FROM po_clob p,
            XMLTable('/PurchaseOrder' PASSING p.OBJECT_VALUE
                     COLUMNS reference   VARCHAR2(30)  PATH 'Reference',
                             lineitem    XMLType       PATH 'LineItems/LineItem') po,
            XMLTable('/LineItem' PASSING po.lineitem
                     COLUMNS itemno      BINARY_DOUBLE PATH '@ItemNumber',
                             description VARCHAR2(256) PATH 'Description',
                             partno      VARCHAR2(14)  PATH 'Part/@Id',
                             quantity    BINARY_DOUBLE PATH 'Part/@Quantity',
                             unitprice   BINARY_DOUBLE PATH 'Part/@UnitPrice') li
       WHERE po.reference = 'SBELL-20021009123335280PDT';
   ```
   
   # Process
   1. First confirm that this is a correct oracle sql syntax, if not please ignore;
   2. Compare SQL definitions in Oficial SQL Doc and ShardingSphere SQL Doc;
   3. If there is any difference in ShardingSphere SQL Doc, please correct them by referring to the Official SQL Doc;
   4. Run mvn install the current_file_module;
   5. Check whether there are any exceptions. If indeed, please fix them. (Especially xxxVisitor.class);
   6. Add new corresponding SQL case in SQL Cases and expected parsed result in Expected Statment XML;
   7. Run SQLParserParameterizedTest to make sure no exceptions.
   
   # Relevant Skills
   1. Master JAVA language
   2. Have a basic understanding of Antlr `g4` file
   3. Be familiar with Oracle SQLs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support parsing Oracle EXPLAIN PLAN sql [shardingsphere]

Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on issue #27143:
URL: https://github.com/apache/shardingsphere/issues/27143#issuecomment-1955389709

   @ilyasahsan123 Assigned, please go ahead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] github-actions[bot] commented on issue #27143: Support parsing Oracle EXPLAIN PLAN sql

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #27143:
URL: https://github.com/apache/shardingsphere/issues/27143#issuecomment-1676080443

   There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support parsing Oracle EXPLAIN PLAN sql [shardingsphere]

Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on issue #27143:
URL: https://github.com/apache/shardingsphere/issues/27143#issuecomment-1958418113

   @ilyasahsan123 Thank you for your test work. I will close this issue now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support parsing Oracle EXPLAIN PLAN sql [shardingsphere]

Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu closed issue #27143: Support parsing Oracle EXPLAIN PLAN sql
URL: https://github.com/apache/shardingsphere/issues/27143


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support parsing Oracle EXPLAIN PLAN sql [shardingsphere]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #27143:
URL: https://github.com/apache/shardingsphere/issues/27143#issuecomment-1784212729

   There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support parsing Oracle EXPLAIN PLAN sql [shardingsphere]

Posted by "ilyasahsan123 (via GitHub)" <gi...@apache.org>.
ilyasahsan123 commented on issue #27143:
URL: https://github.com/apache/shardingsphere/issues/27143#issuecomment-1956487113

   hi @strongduanmu, it turns out that the issue has been resolved with a previous pull request. you might be consider closing this issue.
   
   ![image](https://github.com/apache/shardingsphere/assets/14249648/b8ec233a-4932-4f6a-a051-22edf0f7a166)
   ![image](https://github.com/apache/shardingsphere/assets/14249648/3b66f65d-0cec-4d55-acd2-dab05263d5a7)
   ![image](https://github.com/apache/shardingsphere/assets/14249648/70947aed-72dc-46cd-875d-6e11a25fde81)
   ![image](https://github.com/apache/shardingsphere/assets/14249648/95582d67-29f5-494d-a756-879c0774ba8c)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support parsing Oracle EXPLAIN PLAN sql [shardingsphere]

Posted by "ilyasahsan123 (via GitHub)" <gi...@apache.org>.
ilyasahsan123 commented on issue #27143:
URL: https://github.com/apache/shardingsphere/issues/27143#issuecomment-1954035886

   hi @strongduanmu , could you please assign this to me?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org