You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Brian McDevitt (Code Review)" <ge...@cloudera.org> on 2020/03/23 19:21:00 UTC
[kudu-CR] [KUDU-3085] Create Scala/SBT integration test example.
Brian McDevitt has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15535
Change subject: [KUDU-3085] Create Scala/SBT integration test example.
......................................................................
[KUDU-3085] Create Scala/SBT integration test example.
This example demonstrates the SBT configuration needed to use the kudu-binary JAR for
integration testing.
Change-Id: Ia0ac7abef89c70c5989bd6cb894c8989ed167ec8
---
A examples/scala/sbt-int-test-example/README.adoc
A examples/scala/sbt-int-test-example/build.sbt
A examples/scala/sbt-int-test-example/project/build.properties
A examples/scala/sbt-int-test-example/project/plugins.sbt
A examples/scala/sbt-int-test-example/src/it/resources/logback.xml
A examples/scala/sbt-int-test-example/src/it/scala/org/apache/kudu/scala/examples/KuduExampleITest.scala
A examples/scala/sbt-int-test-example/src/main/scala/org/apache/kudu/scala/examples/KuduExample.scala
A examples/scala/sbt-int-test-example/src/main/scala/org/apache/kudu/scala/examples/Movie.scala
8 files changed, 339 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/15535/1
--
To view, visit http://gerrit.cloudera.org:8080/15535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia0ac7abef89c70c5989bd6cb894c8989ed167ec8
Gerrit-Change-Number: 15535
Gerrit-PatchSet: 1
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
[kudu-CR] KUDU-3085: Create Scala/SBT integration test example.
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15535
to look at the new patch set (#3).
Change subject: KUDU-3085: Create Scala/SBT integration test example.
......................................................................
KUDU-3085: Create Scala/SBT integration test example.
This example demonstrates the SBT configuration needed to use the kudu-binary JAR for
integration testing.
Change-Id: Ia0ac7abef89c70c5989bd6cb894c8989ed167ec8
---
A examples/scala/sbt-int-test-example/README.adoc
A examples/scala/sbt-int-test-example/build.sbt
A examples/scala/sbt-int-test-example/project/build.properties
A examples/scala/sbt-int-test-example/project/plugins.sbt
A examples/scala/sbt-int-test-example/src/it/resources/logback.xml
A examples/scala/sbt-int-test-example/src/it/scala/org/apache/kudu/scala/examples/KuduExampleITest.scala
A examples/scala/sbt-int-test-example/src/main/scala/org/apache/kudu/scala/examples/KuduExample.scala
7 files changed, 302 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/15535/3
--
To view, visit http://gerrit.cloudera.org:8080/15535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia0ac7abef89c70c5989bd6cb894c8989ed167ec8
Gerrit-Change-Number: 15535
Gerrit-PatchSet: 3
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-3085: Create Scala/SBT integration test example.
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15535 )
Change subject: KUDU-3085: Create Scala/SBT integration test example.
......................................................................
KUDU-3085: Create Scala/SBT integration test example.
This example demonstrates the SBT configuration needed to use the kudu-binary JAR for
integration testing.
Change-Id: Ia0ac7abef89c70c5989bd6cb894c8989ed167ec8
Reviewed-on: http://gerrit.cloudera.org:8080/15535
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
---
A examples/scala/sbt-int-test-example/README.adoc
A examples/scala/sbt-int-test-example/build.sbt
A examples/scala/sbt-int-test-example/project/build.properties
A examples/scala/sbt-int-test-example/project/plugins.sbt
A examples/scala/sbt-int-test-example/src/it/resources/logback.xml
A examples/scala/sbt-int-test-example/src/it/scala/org/apache/kudu/scala/examples/KuduExampleITest.scala
A examples/scala/sbt-int-test-example/src/main/scala/org/apache/kudu/scala/examples/KuduExample.scala
7 files changed, 300 insertions(+), 0 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/15535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia0ac7abef89c70c5989bd6cb894c8989ed167ec8
Gerrit-Change-Number: 15535
Gerrit-PatchSet: 5
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-3085: Create Scala/SBT integration test example.
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15535 )
Change subject: KUDU-3085: Create Scala/SBT integration test example.
......................................................................
Patch Set 3:
I still see them. Maybe a mistake amending the patch?
--
To view, visit http://gerrit.cloudera.org:8080/15535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0ac7abef89c70c5989bd6cb894c8989ed167ec8
Gerrit-Change-Number: 15535
Gerrit-PatchSet: 3
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 27 Mar 2020 13:47:14 +0000
Gerrit-HasComments: No
[kudu-CR] [KUDU-3085] Create Scala/SBT integration test example.
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/15535 )
Change subject: [KUDU-3085] Create Scala/SBT integration test example.
......................................................................
Patch Set 1:
(7 comments)
Thanks for the review!
http://gerrit.cloudera.org:8080/#/c/15535/1/examples/scala/sbt-int-test-example/README.adoc
File examples/scala/sbt-int-test-example/README.adoc:
http://gerrit.cloudera.org:8080/#/c/15535/1/examples/scala/sbt-int-test-example/README.adoc@19
PS1, Line 19: :author: Brian McDevitt
> Can you remove these lines? We generally don't attribute authorship in Apac
Done
http://gerrit.cloudera.org:8080/#/c/15535/1/examples/scala/sbt-int-test-example/README.adoc@47
PS1, Line 47: addSbtPlugin("io.phdata" % "sbt-os-detector" % "0.2.0") //<3>
> Can you link to the source for this?
It's linked via the <3> description on line 51.
http://gerrit.cloudera.org:8080/#/c/15535/1/examples/scala/sbt-int-test-example/README.adoc@63
PS1, Line 63: resolvers += "Cloudera" at "https://repository.cloudera.com/artifactory/cloudera-repos",
> You shouldn't need the Cloudera repos here.
Done
http://gerrit.cloudera.org:8080/#/c/15535/1/examples/scala/sbt-int-test-example/README.adoc@71
PS1, Line 71: scalafmtVersion := "1.2.0"
> Maybe remove scalafmt stuff to keep the example minimal?
Done
http://gerrit.cloudera.org:8080/#/c/15535/1/examples/scala/sbt-int-test-example/build.sbt
File examples/scala/sbt-int-test-example/build.sbt:
PS1:
> Same comments from the readme apply here.
Done
http://gerrit.cloudera.org:8080/#/c/15535/1/examples/scala/sbt-int-test-example/project/plugins.sbt
File examples/scala/sbt-int-test-example/project/plugins.sbt:
http://gerrit.cloudera.org:8080/#/c/15535/1/examples/scala/sbt-int-test-example/project/plugins.sbt@21
PS1, Line 21: addSbtPlugin("com.lucidchart" % "sbt-scalafmt-coursier" % "1.12")
> Is coursier required?
No; removed.
http://gerrit.cloudera.org:8080/#/c/15535/1/examples/scala/sbt-int-test-example/src/main/scala/org/apache/kudu/scala/examples/Movie.scala
File examples/scala/sbt-int-test-example/src/main/scala/org/apache/kudu/scala/examples/Movie.scala:
PS1:
> Is this used anywhere? Maybe remove it?
Done
--
To view, visit http://gerrit.cloudera.org:8080/15535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0ac7abef89c70c5989bd6cb894c8989ed167ec8
Gerrit-Change-Number: 15535
Gerrit-PatchSet: 1
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 23 Mar 2020 19:54:57 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3085: Create Scala/SBT integration test example.
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15535 )
Change subject: KUDU-3085: Create Scala/SBT integration test example.
......................................................................
Patch Set 2:
(1 comment)
Looks good. Just one more comment.
http://gerrit.cloudera.org:8080/#/c/15535/2/examples/scala/sbt-int-test-example/README.adoc
File examples/scala/sbt-int-test-example/README.adoc:
http://gerrit.cloudera.org:8080/#/c/15535/2/examples/scala/sbt-int-test-example/README.adoc@24
PS2, Line 24: - Insert rows
I think the example should be updated to insert and scan or this should be updated.
--
To view, visit http://gerrit.cloudera.org:8080/15535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0ac7abef89c70c5989bd6cb894c8989ed167ec8
Gerrit-Change-Number: 15535
Gerrit-PatchSet: 2
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 25 Mar 2020 17:29:32 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3085: Create Scala/SBT integration test example.
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/15535 )
Change subject: KUDU-3085: Create Scala/SBT integration test example.
......................................................................
Patch Set 3:
> Patch Set 2:
>
> (1 comment)
>
> Looks good. Just one more comment.
I removed those lines from the README. The example could be expanded in the future, but it's not really the main point of this example.
--
To view, visit http://gerrit.cloudera.org:8080/15535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0ac7abef89c70c5989bd6cb894c8989ed167ec8
Gerrit-Change-Number: 15535
Gerrit-PatchSet: 3
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 27 Mar 2020 13:45:19 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3085: Create Scala/SBT integration test example.
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15535
to look at the new patch set (#4).
Change subject: KUDU-3085: Create Scala/SBT integration test example.
......................................................................
KUDU-3085: Create Scala/SBT integration test example.
This example demonstrates the SBT configuration needed to use the kudu-binary JAR for
integration testing.
Change-Id: Ia0ac7abef89c70c5989bd6cb894c8989ed167ec8
---
A examples/scala/sbt-int-test-example/README.adoc
A examples/scala/sbt-int-test-example/build.sbt
A examples/scala/sbt-int-test-example/project/build.properties
A examples/scala/sbt-int-test-example/project/plugins.sbt
A examples/scala/sbt-int-test-example/src/it/resources/logback.xml
A examples/scala/sbt-int-test-example/src/it/scala/org/apache/kudu/scala/examples/KuduExampleITest.scala
A examples/scala/sbt-int-test-example/src/main/scala/org/apache/kudu/scala/examples/KuduExample.scala
7 files changed, 300 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/15535/4
--
To view, visit http://gerrit.cloudera.org:8080/15535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia0ac7abef89c70c5989bd6cb894c8989ed167ec8
Gerrit-Change-Number: 15535
Gerrit-PatchSet: 4
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-3085: Create Scala/SBT integration test example.
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15535 )
Change subject: KUDU-3085: Create Scala/SBT integration test example.
......................................................................
Patch Set 4: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0ac7abef89c70c5989bd6cb894c8989ed167ec8
Gerrit-Change-Number: 15535
Gerrit-PatchSet: 4
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 27 Mar 2020 14:18:50 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3085: Create Scala/SBT integration test example.
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/15535 )
Change subject: KUDU-3085: Create Scala/SBT integration test example.
......................................................................
Patch Set 4:
> Patch Set 3:
>
> I still see them. Maybe a mistake amending the patch?
Yes, it helps if I actually push the commit. Derp.
--
To view, visit http://gerrit.cloudera.org:8080/15535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0ac7abef89c70c5989bd6cb894c8989ed167ec8
Gerrit-Change-Number: 15535
Gerrit-PatchSet: 4
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 27 Mar 2020 13:57:16 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3085: Create Scala/SBT integration test example.
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15535
to look at the new patch set (#2).
Change subject: KUDU-3085: Create Scala/SBT integration test example.
......................................................................
KUDU-3085: Create Scala/SBT integration test example.
This example demonstrates the SBT configuration needed to use the kudu-binary JAR for
integration testing.
Change-Id: Ia0ac7abef89c70c5989bd6cb894c8989ed167ec8
---
A examples/scala/sbt-int-test-example/README.adoc
A examples/scala/sbt-int-test-example/build.sbt
A examples/scala/sbt-int-test-example/project/build.properties
A examples/scala/sbt-int-test-example/project/plugins.sbt
A examples/scala/sbt-int-test-example/src/it/resources/logback.xml
A examples/scala/sbt-int-test-example/src/it/scala/org/apache/kudu/scala/examples/KuduExampleITest.scala
A examples/scala/sbt-int-test-example/src/main/scala/org/apache/kudu/scala/examples/KuduExample.scala
7 files changed, 302 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/15535/2
--
To view, visit http://gerrit.cloudera.org:8080/15535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia0ac7abef89c70c5989bd6cb894c8989ed167ec8
Gerrit-Change-Number: 15535
Gerrit-PatchSet: 2
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [KUDU-3085] Create Scala/SBT integration test example.
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15535 )
Change subject: [KUDU-3085] Create Scala/SBT integration test example.
......................................................................
Patch Set 1:
(7 comments)
Thanks for the example! I did a quick first pass.
http://gerrit.cloudera.org:8080/#/c/15535/1/examples/scala/sbt-int-test-example/README.adoc
File examples/scala/sbt-int-test-example/README.adoc:
http://gerrit.cloudera.org:8080/#/c/15535/1/examples/scala/sbt-int-test-example/README.adoc@19
PS1, Line 19: :author: Brian McDevitt
Can you remove these lines? We generally don't attribute authorship in Apache projects.
http://gerrit.cloudera.org:8080/#/c/15535/1/examples/scala/sbt-int-test-example/README.adoc@47
PS1, Line 47: addSbtPlugin("io.phdata" % "sbt-os-detector" % "0.2.0") //<3>
Can you link to the source for this?
http://gerrit.cloudera.org:8080/#/c/15535/1/examples/scala/sbt-int-test-example/README.adoc@63
PS1, Line 63: resolvers += "Cloudera" at "https://repository.cloudera.com/artifactory/cloudera-repos",
You shouldn't need the Cloudera repos here.
http://gerrit.cloudera.org:8080/#/c/15535/1/examples/scala/sbt-int-test-example/README.adoc@71
PS1, Line 71: scalafmtVersion := "1.2.0"
Maybe remove scalafmt stuff to keep the example minimal?
http://gerrit.cloudera.org:8080/#/c/15535/1/examples/scala/sbt-int-test-example/build.sbt
File examples/scala/sbt-int-test-example/build.sbt:
PS1:
Same comments from the readme apply here.
http://gerrit.cloudera.org:8080/#/c/15535/1/examples/scala/sbt-int-test-example/project/plugins.sbt
File examples/scala/sbt-int-test-example/project/plugins.sbt:
http://gerrit.cloudera.org:8080/#/c/15535/1/examples/scala/sbt-int-test-example/project/plugins.sbt@21
PS1, Line 21: addSbtPlugin("com.lucidchart" % "sbt-scalafmt-coursier" % "1.12")
Is coursier required?
http://gerrit.cloudera.org:8080/#/c/15535/1/examples/scala/sbt-int-test-example/src/main/scala/org/apache/kudu/scala/examples/Movie.scala
File examples/scala/sbt-int-test-example/src/main/scala/org/apache/kudu/scala/examples/Movie.scala:
PS1:
Is this used anywhere? Maybe remove it?
--
To view, visit http://gerrit.cloudera.org:8080/15535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0ac7abef89c70c5989bd6cb894c8989ed167ec8
Gerrit-Change-Number: 15535
Gerrit-PatchSet: 1
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 23 Mar 2020 19:43:34 +0000
Gerrit-HasComments: Yes