You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "pdxrunner (GitHub)" <gi...@apache.org> on 2018/09/20 16:02:15 UTC

[GitHub] [geode] pdxrunner opened pull request #2496: GEODE-5741: Modified tests to be independent of environment

Tests using relative paths had depended on running as a user other than root.
The tests expceted that file or directpory creation would fail because the user
would not have permission to write to filesystem root.

A further problem was the several tests had hardcoded '/' in pathnames,
which is incompatible with running on Windows.

* make tests use relative paths
* remove system dependent path separators
* move tests that expect directory creation to fail to StartMemberUtilsTest.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [X] Is your initial contribution a single, squashed commit?

- [X] Does `gradlew build` run cleanly?

- [X] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2496 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pdxrunner commented on issue #2496: GEODE-5741: Modified tests to be independent of environment

Posted by "pdxrunner (GitHub)" <gi...@apache.org>.
Pre-checkin DistributedTest failure on the pre-checkin is a known issue - GEODE-5728 with open PR#2507

[ Full content available at: https://github.com/apache/geode/pull/2496 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pdxrunner closed pull request #2496: GEODE-5741: Modified tests to be independent of environment

Posted by "pdxrunner (GitHub)" <gi...@apache.org>.
[ pull request closed by pdxrunner ]

[ Full content available at: https://github.com/apache/geode/pull/2496 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org