[GitHub] [madlib] orhankislal commented on a change in pull request #423: Association Rules: Improve performance

[GitBox <gi...@apache.org>]

orhankislal commented on a change in pull request #423: Association Rules: Improve performance
URL: https://github.com/apache/madlib/pull/423#discussion_r306485045
 
 

 ##########
 File path: src/ports/postgres/modules/assoc_rules/test/assoc_rules.sql_in
 ##########
 @@ -137,29 +144,63 @@ begin
           assoc_array_eq(t1.post, t2.post) AND
           abs(t1.support - t2.support) < 1E-10 AND
           abs(t1.confidence - t2.confidence) < 1E-10;
+    IF (result2 = 'FAIL') THEN
 
 Review comment:
   I am not sure what you mean. This is literally the test that check for the support and confidence for each rule. It counts the rules that match the fixed values in the expected results table `test2_exp_result` and writes PASS or FAIL to a table if this count is 7. Unless the rules as well as the support and confidence levels match, the result will be a failure. I guess it is a bit unconventional among madlib tests and we might think about changing it in the future.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services