mod_disk_cache read-while-caching patch (try2)

[Niklas Edmundsson <ni...@acc.umu.se>]

Since I haven't got any reply on the mail I sent on Thursday I assume 
that it has been buried in the mod_cache-thread and noone has bothered 
reading it.

In short, the mod_disk_cache read-while-caching patch is usable now 
and I'd like to contribute what's possible upstreams.

I'll start breaking this down into smaller patches, but given the 
recent cache-cleanup-effort I'd like to know how to do it.

* Should I provide patches against httpd-2.2.2 or trunk?
* Should I just attach them to bug #39380 or post them here first?

I suspect that the cache-cleanup-effort will make some of this 
obsolete, but since mod_disk_cache is a dark hole of no error handling 
and doing checks at weird places I suspect that at least those patches 
will prove useful.

/Nikke
-- 
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
  Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se      |     nikke@acc.umu.se
---------------------------------------------------------------------------
  "I am finishing this once and for all." - Buffy
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Re: mod_disk_cache read-while-caching patch (try2)

[Niklas Edmundsson <ni...@acc.umu.se>]

On Tue, 30 May 2006, Paul Querna wrote:

>>> In short, the mod_disk_cache read-while-caching patch is usable now
>>> and I'd like to contribute what's possible upstreams.
>> 
>> Does it make more sens at this time to do all these changes in another 
>> module and leave mod_disk_cache as stable and useable?  call it disk2 or 
>> something...
>
> If its in trunk, thats fine, I wouldn't support backporting these changes to 
> 2.2.x anytime soon however :)

Since the later parts will probably be partly obsoleted by the 
mod_cache cleanup work I don't expect all of it merged. Obvious fixes 
should probably be backported to 2.2.x though, I'm starting with those 
to get them out of the way and then you'll be the judge.


/Nikke
-- 
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
  Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se      |     nikke@acc.umu.se
---------------------------------------------------------------------------
  I've seen the procedure hundreds of times. - Qwark
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Re: mod_disk_cache read-while-caching patch (try2)

[Paul Querna <ch...@force-elite.com>]

Brian Akins wrote:
> Niklas Edmundsson wrote:
> 
>> In short, the mod_disk_cache read-while-caching patch is usable now
>> and I'd like to contribute what's possible upstreams.
>>
> 
> Does it make more sens at this time to do all these changes in another 
> module and leave mod_disk_cache as stable and useable?  call it disk2 or 
> something...

If its in trunk, thats fine, I wouldn't support backporting these 
changes to 2.2.x anytime soon however :)

Worst case, we can always create a devel-branch in subversion, but I 
don't see any reason to make a mod_disk_cache2 module.

-Paul

Re: mod_disk_cache read-while-caching patch (try2)

[Brian Akins <br...@turner.com>]

Niklas Edmundsson wrote:

> In short, the mod_disk_cache read-while-caching patch is usable now
> and I'd like to contribute what's possible upstreams.
>

Does it make more sens at this time to do all these changes in another 
module and leave mod_disk_cache as stable and useable?  call it disk2 or 
something...

CacheEnable disk2 /




-- 
Brian Akins
Lead Systems Engineer
CNN Internet Technologies