You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@lyra.org> on 2002/05/14 18:03:51 UTC

Re: svn commit: rev 1949 - branches/issue-654-dev/subversion/libsvn_fs

On Mon, May 13, 2002 at 08:57:40PM -0500, cmpilato@tigris.org wrote:
>...
> +++ branches/issue-654-dev/subversion/libsvn_fs/copies-table.h	Mon May 13 20:57:23 2002
>...
> +svn_error_t *svn_fs__delete_copy (svn_fs_t *fs,
> +                                  const char *copy_id,
> +                                  trail_t *trail);
>...
> +svn_error_t *svn_fs__get_copy (svn_fs__copy_t **copy_p,
> +                               svn_fs_t *fs,
> +                               const char *copy_id,
> +                               trail_t *trail);

I thought your node, copy, and txn IDs would be integers. Thus, the COPY_ID
parameter here would be an 'int' type.  (whether apr_intXX_t or a new
internal type such as svn_fs__table_id_t).

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 1949 - branches/issue-654-dev/subversion/libsvn_fs

Posted by cm...@collab.net.
Greg Stein <gs...@lyra.org> writes:

> On Mon, May 13, 2002 at 08:57:40PM -0500, cmpilato@tigris.org wrote:
> >...
> > +++ branches/issue-654-dev/subversion/libsvn_fs/copies-table.h	Mon May 13 20:57:23 2002
> >...
> > +svn_error_t *svn_fs__delete_copy (svn_fs_t *fs,
> > +                                  const char *copy_id,
> > +                                  trail_t *trail);
> >...
> > +svn_error_t *svn_fs__get_copy (svn_fs__copy_t **copy_p,
> > +                               svn_fs_t *fs,
> > +                               const char *copy_id,
> > +                               trail_t *trail);
> 
> I thought your node, copy, and txn IDs would be integers. Thus, the COPY_ID
> parameter here would be an 'int' type.  (whether apr_intXX_t or a new
> internal type such as svn_fs__table_id_t).

You're correct, and I would have found that out as soon as I converted
the svn_fs_id_t structure. :-)  

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org