You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/01/07 17:20:06 UTC
[GitHub] merlimat commented on a change in pull request #1033: Implement TopicMetadata for MessageRouter in C++ client
merlimat commented on a change in pull request #1033: Implement TopicMetadata for MessageRouter in C++ client
URL: https://github.com/apache/incubator-pulsar/pull/1033#discussion_r160054966
##########
File path: pulsar-client-cpp/lib/PartitionedProducerImpl.cc
##########
@@ -37,18 +39,28 @@ namespace pulsar {
const ProducerConfiguration& config):client_(client),
destinationName_(destinationName),
topic_(destinationName_->toString()),
- numPartitions_(numPartitions),
conf_(config),
state_(Pending)
{
numProducersCreated_ = 0;
+
+ topicMetadata_ = std::unique_ptr<TopicMetadata>(new TopicMetadataImpl(numPartitions));
Review comment:
In general we cannot yet use all the c++11 feature in general lib. We could use a `boost::scoped_ptr` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services