You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Lee-W (via GitHub)" <gi...@apache.org> on 2026/07/22 10:59:32 UTC

[PR] Document sensitive-data exposure risk in LLMRetryPolicy [airflow]

Lee-W opened a new pull request, #70229:
URL: https://github.com/apache/airflow/pull/70229

   _classify() sends the raw exception message verbatim to the configured external LLM provider for error classification. That message can carry credentials, connection strings, or other PII surfaced by a failing task, which users may not realize is being sent to a third party.
   
    <!-- SPDX-License-Identifier: Apache-2.0
         https://www.apache.org/licenses/LICENSE-2.0 -->
   
   <!--
   Thank you for contributing!
   
   Please provide above a brief description of the changes made in this pull request.
   Write a good git commit message following this guide: https://chris.beams.io/posts/git-commit/
   
   Please make sure that your code changes are covered with tests.
   And in case of new features or big changes remember to adjust the documentation.
   
   For user-facing UI changes, please attach before/after screenshots (or a short
   screen recording) so reviewers can assess the visual impact.
   
   Feel free to ping (in general) for the review if you do not see reaction for a few days
   (72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
   
   In case of an existing issue, reference it using one of the following:
   
   * closes: #ISSUE
   * related: #ISSUE
   -->
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, please
   change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
   -->
   
   - [ ] Yes (please specify the tool below)
   
   <!--
   Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   -->
   
   ---
   
   * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Redact secrets from LLMRetryPolicy classification prompts [airflow]

Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #70229:
URL: https://github.com/apache/airflow/pull/70229#discussion_r3680879578


##########
providers/common/ai/src/airflow/providers/common/ai/policies/retry.py:
##########
@@ -109,12 +133,15 @@ def __init__(
         instructions: str | None = None,
         fallback_rules: list[RetryRule] | None = None,
         timeout: float = 30.0,
+        *,
+        redact_exception: bool = True,

Review Comment:
   `providers/common/ai/docs/retry_policies.rst` isn't updated here: the Parameters table lists the five existing constructor args but not `redact_exception`, and "How it works" step 1 still reads "Sends the exception message to the configured LLM". The "Local LLM support" section right below that table is framed as the mitigation for "environments where exception data must not leave the infrastructure", which now understates the default behaviour. Once the page carries that guidance, the 15-line `.. warning::` block here could shrink to a pointer rather than restating the `:param redact_exception:` text.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Redact secrets from LLMRetryPolicy classification prompts [airflow]

Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #70229:
URL: https://github.com/apache/airflow/pull/70229#discussion_r3688278330


##########
providers/common/ai/src/airflow/providers/common/ai/policies/retry.py:
##########
@@ -109,12 +133,15 @@ def __init__(
         instructions: str | None = None,
         fallback_rules: list[RetryRule] | None = None,
         timeout: float = 30.0,
+        *,
+        redact_exception: bool = True,

Review Comment:
   Yep, updated. I do think we should have a better way to keep these in sync, but I'd rather keep this as is for now and address that in a follow-up PR.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Redact secrets from LLMRetryPolicy classification prompts [airflow]

Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W merged PR #70229:
URL: https://github.com/apache/airflow/pull/70229


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org