You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2020/06/04 13:16:52 UTC
[Bug 64498] New: Incorrect OSGi Manifests
https://bz.apache.org/bugzilla/show_bug.cgi?id=64498
Bug ID: 64498
Summary: Incorrect OSGi Manifests
Product: Tomcat 10
Version: 10.0.0-M5
Hardware: All
OS: Mac OS X 10.1
Status: NEW
Severity: normal
Priority: P2
Component: Packaging
Assignee: dev@tomcat.apache.org
Reporter: volosied+apache@gmail.com
Target Milestone: ------
Hello,
As I was incorporating the Tomcat EL bundles in Open Liberty, we noticed the
manifests for Tomcat jars are slightly malformed/incorrect.
- Bundle-Version should not use a dash: Bundle-Version: 10.0.0-M5
- Export-package is missing the package version
The manfiest indicates that these jars were build with Bnd:
Tool: Bnd-5.0.1.202003231327
Bnd would not have included the dash, so these may have been edited before
being uploaded to maven?
Links:
https://repo1.maven.org/maven2/org/apache/tomcat/tomcat-jasper-el/10.0.0-M5/
https://repo1.maven.org/maven2/org/apache/tomcat/tomcat-jasper/10.0.0-M5/
And this appears to be the case with others others as well.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 64498] Incorrect OSGi Manifests
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64498
BJ Hargrave <bj...@bjhargrave.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bj@bjhargrave.com,
| |rotty3000@apache.org
--- Comment #2 from BJ Hargrave <bj...@bjhargrave.com> ---
We need to update the .bnd files to cleanup maven versions for the
Bundle-Version headers. Something like:
Bundle-Version: ${cleanup_version;@VERSION@}
Ray Augé is looking into a PR to fix this.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 64498] Incorrect OSGi Manifests
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64498
--- Comment #4 from BJ Hargrave <bj...@bjhargrave.com> ---
(In reply to BJ Hargrave from comment #2)
> Bundle-Version: ${cleanup_version;@VERSION@}
That should have been:
Bundle-Version: ${version_cleanup;@VERSION@}
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 64498] Incorrect OSGi Manifests
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64498
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #5 from Mark Thomas <ma...@apache.org> ---
Fixed in:
- master for 10.0.0-M7 onwards
- 9.0.x for 9.0.37 onwards
Earlier versions aren't affected as they don't use BND.
9.0.x would only be affected if a qualifier was added to the version number.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 64498] Incorrect OSGi Manifests
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64498
--- Comment #3 from rotty3000 <ra...@liferay.com> ---
See https://github.com/apache/tomcat/pull/294
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 64498] Incorrect OSGi Manifests
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64498
--- Comment #1 from volosied+apache@gmail.com ---
This dash creates parsing issues:
parse
java.lang.IllegalArgumentException: Invalid version in bundle
org.apache.tomcat-el-api=: 10.0.0-M5
at
aQute.bnd.osgi.resource.ResourceBuilder.addManifest(ResourceBuilder.java:171)
at
aQute.bnd.osgi.resource.ResourceBuilder.addFile(ResourceBuilder.java:716)
at
aQute.bnd.repository.maven.provider.IndexFile.parseSingle(IndexFile.java:289)
at
aQute.bnd.repository.maven.provider.IndexFile.parseSingleOrMultiFile(IndexFile.java:272)
at
aQute.bnd.repository.maven.provider.IndexFile.lambda$update$3(IndexFile.java:230
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org