You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Allen Wittenauer (JIRA)" <ji...@apache.org> on 2016/03/24 23:25:25 UTC
[jira] [Comment Edited] (HADOOP-11393) Revert HADOOP_PREFIX, go
back to HADOOP_HOME
[ https://issues.apache.org/jira/browse/HADOOP-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15211059#comment-15211059 ]
Allen Wittenauer edited comment on HADOOP-11393 at 3/24/16 10:25 PM:
---------------------------------------------------------------------
A local run w/out unit tests resulted in the these failures:
|| Vote || Subsystem || Runtime || Comment ||
| -1 | checkstyle | 1m 21s | root: patch generated 4 new + 172 |
| | | | unchanged - 8 fixed = 176 total (was 180) |
| -1 | whitespace | 0m 0s | The patch has 2 line(s) that end in |
| | | | whitespace. Use git apply |
| | | | --whitespace=fix. |
Checkstyle issues are all line length problems. I suspect the 8 fixed are also line length as well.
I'll fire off unit tests tonight.
was (Author: aw):
A local run w/out unit tests resulted in the these failures:
| Vote | Subsystem | Runtime | Comment
============================================================================
| -1 | checkstyle | 1m 21s | root: patch generated 4 new + 172 |
| | | | unchanged - 8 fixed = 176 total (was 180) |
| -1 | whitespace | 0m 0s | The patch has 2 line(s) that end in |
| | | | whitespace. Use git apply |
| | | | --whitespace=fix. |
Checkstyle issues are all line length problems. I suspect the 8 fixed are also line length as well.
I'll fire off unit tests tonight.
> Revert HADOOP_PREFIX, go back to HADOOP_HOME
> --------------------------------------------
>
> Key: HADOOP-11393
> URL: https://issues.apache.org/jira/browse/HADOOP-11393
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 3.0.0
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Attachments: HADOOP-11393-00.patch, HADOOP-11393.01.patch, HADOOP-11393.02.patch
>
>
> Today, Windows and parts of the Hadoop source code still use HADOOP_HOME. The switch to HADOOP_PREFIX back in 0.21 or so didn't really accomplish what it was intended to do and only helped confuse the situation.
> _HOME is a much more standard suffix and is, in fact, used for everything in Hadoop except for the top level project home. I think it would be beneficial to use HADOOP_HOME in the shell code as the Official(tm) variable, still honoring HADOOP_PREFIX if it is set.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)