You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by bhaisaab <gi...@git.apache.org> on 2016/01/27 02:21:31 UTC
[GitHub] cloudstack pull request: Support jdk8 mvnupgrades
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1370
Support jdk8 mvnupgrades
Was learning about JDK8, lambdas, streams etc today. Thought it would be a good idea to get ACS codebase to latest mvn and jdk8. This is a WIP branch pushed on ACS remote so feel free to push changes if you're a committer or send PR.
Major changes:
- Moved to latest JDK8
- Moved to latest Maven 3.3.9 (-T threaded compilations appears faster)
- Upgraded several dependencies to latest minor versions (or major in few cases)
What fails/unsupported or TODOs:
- Unit tests in cloud-server and few other places
- F5 plugin fails, tried to resolve the issue but I was unable to grok it
- Major spring framework version (that would be a lot of work on its own)
- Major servlet version changes
- Fix packaging, init.d/system.d JAVA_HOME paths
- Check ACS agents with JDK/JRE8 (kvm, cpvm, ssvm)
- Check and configure GC related changes wrt JRE7/JRE8 (in any configs, say tomcat configs)
- Check agains compatibility guide: http://www.oracle.com/technetwork/java/javase/8-compatibility-guide-2156366.html
What works:
- Compiling in -Dnoredist with -DskipTests to test if ACS codebase (minus unit tests) worked (non-issue once we fix the failing unit tests)
- Deploy db worked
- Running the management server locally with Java8
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/cloudstack support-jdk8-mvnupgrades
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1370.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1370
----
commit 998c41337a7ae4141b001be5561e7d7c338517f3
Author: Rohit Yadav <ro...@shapeblue.com>
Date: 2016-01-27T00:05:05Z
cloudstack: Switch build toolchain, travis, docker to JDK8
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
commit c4ff013b997ea79a7aa8d8075ed4c0703e70e468
Author: Rohit Yadav <ro...@shapeblue.com>
Date: 2016-01-27T00:30:21Z
framework/quota: Fix checkstyle issue
Fixes a checkstyle issue for enums, breaks with newer checkstyle versions
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
commit bf8fbd36aa045a61e3fab08c8c7ca41056154928
Author: Rohit Yadav <ro...@shapeblue.com>
Date: 2016-01-27T00:41:02Z
maven: Upgrade dependency versions and maven 3.3.9
Skipped: (but upgraded to latest minor release)
- Major spring framework version
- Servlet version
- Embedded jetty version
- Mockito version (beta)
- Mysql lib minor version upgrade (breaks mysql-ha plugin)
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
commit 7d3fab4060346a25f5f6fd52e819cea255149ebd
Author: Rohit Yadav <ro...@shapeblue.com>
Date: 2016-01-27T00:31:06Z
plugins: Comment out F5, breaks with Java8
Comment out F5 plugin which breaks for an unresolved issue:
cloudstack/plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java
--> cannot access Stub
We should fix it once we can get an updated iControl.jar or get this issue fixed
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.9+] WIP: Support Java 8, Maven 3.3, Up...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1370#issuecomment-175477214
@wido I was getting some compilation issue specifically to F5, to which someone previously on ML had advised an issue related to dependency version so I've included upgrading dependency version (to stable/latest minor revision but no major version changes causing compatibility issues). Unfortunately, I did that but F5 was still not happy while getting compiled.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.9+] WIP: Support Java 8, Maven 3.3, Up...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1370#issuecomment-175328669
cc @DaanHoogland @jburwell @wido @wilderrodrigues @remibergsma @borisroman and others
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.9+] WIP: Support Java 8, Maven 3.3, Up...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1370#issuecomment-175490258
To ease transition, it seems like the first step should be to support running ACS built to 1.7 on a 1.8 runtime. This approach would allow customers unprepared to transition to continue using Java7. We would then notify users that Java7 support has been deprecated and will be removed in two releases (two months).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.9+] WIP: Support Java 8, Maven 3.3, Up...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1370#issuecomment-175473551
I agree with switching to Java 8, but shouldn't this be a small PR first where we ONLY switch to Java 8?
Other PRs can follow up quickly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.9+] WIP: Support Java 8, Maven 3.3, Up...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1370#discussion_r51005339
--- Diff: engine/api/pom.xml ---
@@ -38,7 +38,7 @@
<dependency>
<groupId>org.apache.cxf</groupId>
<artifactId>cxf-bundle-jaxrs</artifactId>
- <version>2.7.13</version>
+ <version>2.7.18</version>
--- End diff --
can the version become a var in the root pom?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.9+] WIP: Support Java 8, Maven 3.3, Up...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1370#issuecomment-175523813
@bhaisaab if we make the packaging require Java 1.8, then users will be automatically upgraded -- defeating the purpose of the deprecation. It seems like an appropriate first step is to audit all dependencies for Java8 support, and upgrade all affected dependencies. For example, we need to upgrade to Spring 4 because (Spring 3 does not support Java 8)[http://spring.io/blog/2013/05/21/spring-framework-4-0-m1-3-2-3-available/]. In my opinion, we should perform the dependency upgrades as part of 4.9.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.9+] WIP: Support Java 8, Maven 3.3, Up...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab closed the pull request at:
https://github.com/apache/cloudstack/pull/1370
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.9+] WIP: Support Java 8, Maven 3.3, Up...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1370#issuecomment-175492873
Alright, let's keep this PR hanging then. We should then open another PR which fixes the packaging first to switch from JRE7 to JRE8 along with any JAVA_OPT or tomcat config changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.9+] WIP: Support Java 8, Maven 3.3, Up...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1370#discussion_r51006290
--- Diff: engine/api/pom.xml ---
@@ -38,7 +38,7 @@
<dependency>
<groupId>org.apache.cxf</groupId>
<artifactId>cxf-bundle-jaxrs</artifactId>
- <version>2.7.13</version>
+ <version>2.7.18</version>
--- End diff --
Sure.
Wondering if we can remove many of the engine/{projects}; not sure where it is used or who uses that. Looks like a WIP attempt to creating a RESTful api server.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---