You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "lilykuang (via GitHub)" <gi...@apache.org> on 2023/01/31 18:55:21 UTC

[GitHub] [superset] lilykuang commented on a diff in pull request #22914: chore: upgrade packages for react v17 upgrade

lilykuang commented on code in PR #22914:
URL: https://github.com/apache/superset/pull/22914#discussion_r1092353148


##########
superset-frontend/package.json:
##########
@@ -183,13 +183,13 @@
     "react-reverse-portal": "^2.1.1",
     "react-router-dom": "^5.1.2",
     "react-search-input": "^0.11.3",
-    "react-select": "^3.1.0",
-    "react-sortable-hoc": "^1.11.0",
+    "react-select": "^3.2.0",
+    "react-sortable-hoc": "^2.0.0",

Review Comment:
   yes there is no breaking change for react-sortable-hoc v2 and only works up to react v17. We will need migrate from react-sortable-hoc to @dnd-kit/sortable for react v18 https://github.com/clauderic/react-sortable-hoc#readme



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org