[GitHub] [incubator-superset] etr2460 commented on a change in pull request #10839: Eslint dependencies versions updates

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#discussion_r487270741



##########
File path: superset-frontend/.eslintrc.js
##########
@@ -17,7 +17,12 @@
  * under the License.
  */
 module.exports = {
-  extends: ['airbnb', 'prettier'],
+  extends: [
+    'airbnb',
+    'prettier',
+    'prettier/@typescript-eslint',

Review comment:
       why does the default need to extend prettier/@typescript? shouldn't this only be needed for `.ts` and `.tsx` files?

##########
File path: superset-frontend/.eslintrc.js
##########
@@ -72,19 +78,26 @@ module.exports = {
         ],
         'import/no-named-as-default': 0,
         'import/no-named-as-default-member': 0,
+        'import/no-useless-path-segments': 0,
         'import/prefer-default-export': 0,
         indent: 0,
         'jsx-a11y/anchor-has-content': 0,
-        'jsx-a11y/href-no-hash': 0,

Review comment:
       did this rule get removed from the airbnb defaults? or was it renamed to `anchor-is-valid`?

##########
File path: superset-frontend/package.json
##########
@@ -121,6 +121,7 @@
     "mousetrap": "^1.6.1",
     "mustache": "^2.2.1",
     "omnibar": "^2.1.1",
+    "path": "^0.12.7",

Review comment:
       why do we need to add this to the deps? I don't see it used anywhere?

##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
     "rison": "^0.1.1",
     "shortid": "^2.2.6",
     "urijs": "^1.18.10",
-    "use-query-params": "^0.4.5"
+    "use-query-params": "^0.4.5",
+    "zlib": "^1.0.5"

Review comment:
       why do we need to add this to the deps? I don't see it used anywhere?

##########
File path: superset-frontend/src/explore/components/controls/SelectAsyncControl.jsx
##########
@@ -76,7 +76,7 @@ const SelectAsyncControl = props => {
         dataEndpoint={dataEndpoint}
         onChange={onSelectionChange}
         onAsyncError={errorMsg =>
-          this.props.addDangerToast(`${onAsyncErrorMessage}: ${errorMsg}`)
+          props.addDangerToast(`${onAsyncErrorMessage}: ${errorMsg}`)

Review comment:
       ooo, nice catch!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org