[GitHub] [poi] rascmatt commented on a diff in pull request #443: [Bug-66532] Improve performance of SheetDataWriter

["rascmatt (via GitHub)" <gi...@apache.org>]

rascmatt commented on code in PR #443:
URL: https://github.com/apache/poi/pull/443#discussion_r1140650040


##########
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SheetDataWriter.java:
##########
@@ -397,46 +397,51 @@ protected void outputEscapedString(String s) throws IOException {
             return;
         }
 
-        for (Iterator<String> iter = CodepointsUtil.iteratorFor(s); iter.hasNext(); ) {
-            String codepoint = iter.next();
+        for (int i = 0; i < s.length(); i++) {
+            final int codepoint = s.codePointAt(i);

Review Comment:
   I might need to improve the readability of the loop, however I think this is covered by line 441, where (in case of a character pair) the counter is additionally increased.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org