You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@commons.apache.org by se...@apache.org on 2009/03/26 21:54:47 UTC

svn commit: r758850 - /commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveEntry.java

Author: sebb
Date: Thu Mar 26 20:54:47 2009
New Revision: 758850

URL: http://svn.apache.org/viewvc?rev=758850&view=rev
Log:
COMPRESS-55 Throw error if user attempts to set an invalid mode

Modified:
    commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveEntry.java

Modified: commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveEntry.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveEntry.java?rev=758850&r1=758849&r2=758850&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveEntry.java (original)
+++ commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveEntry.java Thu Mar 26 20:54:47 2009
@@ -611,9 +611,7 @@
         case C_ISNWK:
             break;
         default:
-            // FIXME: testCpioUnarchive fails if I change the line to
-            // actually throw the excpetion
-            new IllegalArgumentException(
+            throw new IllegalArgumentException(
                     "Unknown mode. "
                     + "Full: " + Long.toHexString(mode) 
                     + " Masked: " + Long.toHexString(maskedMode));