You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "jychen7 (via GitHub)" <gi...@apache.org> on 2023/06/10 02:38:23 UTC

[GitHub] [avro] jychen7 opened a new pull request, #2278: AVRO-3776: [ruby] fix encoding for decimal logical type

jychen7 opened a new pull request, #2278:
URL: https://github.com/apache/avro/pull/2278

   ## What is the purpose of the change
   
   fix https://issues.apache.org/jira/browse/AVRO-3776
   
   
   ## Verifying this change
   
   *(Please pick one of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   - *Extended interop tests to verify consistent valid schema names between SDKs*
   - *Added test that validates that Java throws an AvroRuntimeException on invalid binary data*
   - *Manually verified the change by building the website and checking the new redirect*
   
   
   ## Documentation
   
   - Does this pull request introduce a new feature? (yes / no)
   - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [avro] jychen7 closed pull request #2278: AVRO-3776: [ruby] fix encoding for decimal logical type

Posted by "jychen7 (via GitHub)" <gi...@apache.org>.
jychen7 closed pull request #2278: AVRO-3776: [ruby] fix encoding for decimal logical type
URL: https://github.com/apache/avro/pull/2278


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [avro] jychen7 commented on pull request #2278: AVRO-3776: [ruby] fix encoding for decimal logical type

Posted by "jychen7 (via GitHub)" <gi...@apache.org>.
jychen7 commented on PR #2278:
URL: https://github.com/apache/avro/pull/2278#issuecomment-1585440965

   Not an issue, I give wrong schema input
   
   It is tricky that logical type need to wrap inner
   
   ### Wrong
   ```
   {
               "type": "record",
               "name": "Order",
               "fields" : [
                   {
                       "name": "sales",
                         "type": "bytes",
                         "logicalType": "decimal",
                         "precision": 4,
                         "scale": 2    
                   }  
               ]
           }
   ```
   ### Valid
   ```
   {
               "type": "record",
               "name": "Order",
               "fields" : [
                   {
                       "name": "sales",
                       "type": {
                           "type": "bytes",
                           "logicalType": "decimal",
                           "precision": 4,
                           "scale": 2    
                       }
                   }  
               ]
           }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org