You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "nsivabalan (via GitHub)" <gi...@apache.org> on 2023/08/26 20:15:56 UTC
[GitHub] [hudi] nsivabalan commented on a diff in pull request #9543: [HUDI-6445] Fixing metrics to use console type in tests
nsivabalan commented on code in PR #9543:
URL: https://github.com/apache/hudi/pull/9543#discussion_r1306561244
##########
hudi-client/hudi-java-client/src/test/java/org/apache/hudi/testutils/TestHoodieMetadataBase.java:
##########
@@ -303,9 +303,7 @@ protected HoodieWriteConfig.Builder getWriteConfigBuilder(HoodieFailedWritesClea
.ignoreSpuriousDeletes(validateMetadataPayloadConsistency)
.build())
.withMetricsConfig(HoodieMetricsConfig.newBuilder().on(enableMetrics)
- .withExecutorMetrics(enableMetrics).build())
- .withMetricsGraphiteConfig(HoodieMetricsGraphiteConfig.newBuilder()
- .usePrefix("unit-test").build())
+ .withExecutorMetrics(enableMetrics).withReporterType(MetricsReporterType.CONSOLE.name()).build())
Review Comment:
sounds fair
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org