You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2005/12/15 17:20:29 UTC
[Bug 4737] New: rewriting headers with leading spaces
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4737
Summary: rewriting headers with leading spaces
Product: Spamassassin
Version: 3.0.3
Platform: Other
OS/Version: other
Status: NEW
Severity: minor
Priority: P4
Component: spamassassin
AssignedTo: dev@spamassassin.apache.org
ReportedBy: Klaus.Mueller@danet.de
when a spam-messages has a subject-header with leading space (i.e. more than 1
space after the "Subject:") the subject-tag will be inserted after all spaces.
Outlook will include all but the first space after the ":" in the Subject, so
that matching against ^subject-tag will not work.
The rewrite-tag should be inserted imediatly following the ":" or ": ".
I assume this is also present in 3.1.0.
The place to fix should be in the get_pristine_header-function. As this seems to
be a pretty basic function, someone more experienced with spamassassin and the
possible sideeffects should change this.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4737] [review] rewriting headers with leading spaces
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4737
------- Additional Comments From felicity@apache.org 2006-08-02 14:43 -------
(In reply to comment #4)
> that change will discard the extra spaces, replacing them with just a single
> space, right? I think that's fine, anyway, just noting it
Yes, the idea is to trim the leading whitespace and have the header markup at
the front of the header (apparently some MUAs trim the first space, but not any
additional whitespace). Since we store the original header in X-Spam-Prev,
we're not really losing anything. :)
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4737] [review] rewriting headers with leading spaces
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4737
------- Additional Comments From jm@jmason.org 2006-08-02 09:19 -------
+1
that change will discard the extra spaces, replacing them with just a single
space, right? I think that's fine, anyway, just noting it
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4737] rewriting headers with leading spaces
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4737
felicity@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |3.1.5
------- Additional Comments From felicity@apache.org 2006-08-02 01:33 -------
hrm. this does still happen with 3.1!
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4737] rewriting headers with leading spaces
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4737
------- Additional Comments From Klaus.Mueller@danet.de 2005-12-16 11:16 -------
Some more investigation shows, that the error is not in get_pristine_header but
in rewrite_no_report_safe.
The rewriting regexp (Line 912; PreMsgStatus.pm 3.0.3; Line 910 3.1.0) should be:
s/^([^:]+:)(?:[ \t]*(?:\Q${tag}\E)?[ \t]*)/$1 ${tag} /i;
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4737] [review] rewriting headers with leading spaces
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4737
sidney@sidney.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 1 vote |ready for commit
------- Additional Comments From sidney@sidney.com 2006-08-20 20:45 -------
+1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4737] [review] rewriting headers with leading spaces
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4737
felicity@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|rewriting headers with |[review] rewriting headers
|leading spaces |with leading spaces
Status Whiteboard| |needs 2 votes
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4737] [review] rewriting headers with leading spaces
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4737
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 2 votes |needs 1 vote
------- Additional Comments From jm@jmason.org 2006-08-02 15:37 -------
'Since we store the original header in X-Spam-Prev,
we're not really losing anything.'
ah, of course, forgot about that!
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4737] [review] rewriting headers with leading spaces
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4737
felicity@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From felicity@apache.org 2006-08-20 21:25 -------
Sending lib/Mail/SpamAssassin/PerMsgStatus.pm
Transmitting file data .
Committed revision 433054.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4737] [review] rewriting headers with leading spaces
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4737
------- Additional Comments From felicity@apache.org 2006-08-02 01:51 -------
Created an attachment (id=3622)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3622&action=view)
suggested patch
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.