You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "celeste-zeng (via GitHub)" <gi...@apache.org> on 2023/08/14 19:32:22 UTC

[GitHub] [beam] celeste-zeng opened a new pull request, #27996: Add required dependency for Github Actions Java ARM Test Suite.

celeste-zeng opened a new pull request, #27996:
URL: https://github.com/apache/beam/pull/27996

   - Test failed due to missing dependency, added in this PR.
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #27996: Add required dependency for Github Actions Java ARM Test Suite.

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #27996:
URL: https://github.com/apache/beam/pull/27996#issuecomment-1678337767

   Looks like phrase comment workflow has some bug:
   
   ```
   Setup repository
   
   Prepare all required actions
   Getting action download info
   Run ./.github/actions/setup-action
   Run echo "The comment Run Java_Examples_Dataflow_ARM PostCommit does not match the phrase for this instance:  Run Java_Examples_Dataflow_ARM PostCommit [1](https://github.com/apache/beam/actions/runs/5862881738/job/15895405830#step:4:1)1. Exiting."
   The comment Run Java_Examples_Dataflow_ARM PostCommit does not match the phrase for this instance:  Run Java_Examples_Dataflow_ARM PostCommit 11. Exiting.
   Error: Process completed with exit code 1.
   ```
   https://github.com/apache/beam/actions/runs/5862881738/job/15895405830


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #27996: Add required dependency for Github Actions Java ARM Test Suite.

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27996:
URL: https://github.com/apache/beam/pull/27996#issuecomment-1678021325

   Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] celeste-zeng commented on pull request #27996: Add required dependency for Github Actions Java ARM Test Suite.

Posted by "celeste-zeng (via GitHub)" <gi...@apache.org>.
celeste-zeng commented on PR #27996:
URL: https://github.com/apache/beam/pull/27996#issuecomment-1678342941

   Due to https://github.com/apache/beam/pull/27852, I think now all rerun requires a version specified.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on a diff in pull request #27996: Add required dependency for Github Actions Java ARM Test Suite.

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #27996:
URL: https://github.com/apache/beam/pull/27996#discussion_r1294981107


##########
.github/workflows/beam_PostCommit_Java_Examples_Dataflow_ARM.yml:
##########
@@ -129,4 +129,6 @@ jobs:
         uses: actions/upload-artifact@v3
         with:
           name: java-code-coverage-report
-          path: "**/build/test-results/**/*.xml"
+          path: |
+              "**/build/test-results/**/*.xml"
+              "**/build/reports/tests/**/*.xml"

Review Comment:
   upload all files in reports/tests  (html, css, etc)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #27996: Add required dependency for Github Actions Java ARM Test Suite.

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #27996:
URL: https://github.com/apache/beam/pull/27996#issuecomment-1678346442

   It's not classNotFoundException now, but `java.lang.IllegalArgumentException at WordCountIT.java:58`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn merged pull request #27996: Add required dependency for Github Actions Java ARM Test Suite.

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #27996:
URL: https://github.com/apache/beam/pull/27996


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #27996: Add required dependency for Github Actions Java ARM Test Suite.

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #27996:
URL: https://github.com/apache/beam/pull/27996#issuecomment-1678335405

   Run Java_Examples_Dataflow_ARM PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #27996: Add required dependency for Github Actions Java ARM Test Suite.

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27996:
URL: https://github.com/apache/beam/pull/27996#issuecomment-1679489753

   Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @Abacn for label build.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #27996: Add required dependency for Github Actions Java ARM Test Suite.

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #27996:
URL: https://github.com/apache/beam/pull/27996#issuecomment-1678337865

   Run Java_Examples_Dataflow_ARM PostCommit 8


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #27996: Add required dependency for Github Actions Java ARM Test Suite.

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #27996:
URL: https://github.com/apache/beam/pull/27996#issuecomment-1679481747

   https://github.com/apache/beam/blob/3530d44745a864970a265c7996069d7cde95e8bf/runners/google-cloud-dataflow-java/arm/build.gradle#L89
   
   java${javaVer}_sdk -> ${javaVer}_sdk


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on a diff in pull request #27996: Add required dependency for Github Actions Java ARM Test Suite.

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #27996:
URL: https://github.com/apache/beam/pull/27996#discussion_r1294982260


##########
.github/workflows/beam_PostCommit_Java_Examples_Dataflow_ARM.yml:
##########
@@ -129,4 +129,6 @@ jobs:
         uses: actions/upload-artifact@v3

Review Comment:
   a condition
   
   `if: always()`
   
   should make upload step alway run. ref: https://github.com/actions/upload-artifact/issues/328#issuecomment-1159824887



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #27996: Add required dependency for Github Actions Java ARM Test Suite.

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #27996:
URL: https://github.com/apache/beam/pull/27996#issuecomment-1679472863

   https://github.com/apache/beam/blob/3530d44745a864970a265c7996069d7cde95e8bf/runners/google-cloud-dataflow-java/arm/build.gradle#L101
   
   Change to:
   
   `--workerMachineType`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] celeste-zeng commented on pull request #27996: Add required dependency for Github Actions Java ARM Test Suite.

Posted by "celeste-zeng (via GitHub)" <gi...@apache.org>.
celeste-zeng commented on PR #27996:
URL: https://github.com/apache/beam/pull/27996#issuecomment-1677943497

   R:@abacn


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org