[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8490: [SIP-15] Adding grace period

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #8490: [SIP-15] Adding grace period
URL: https://github.com/apache/incubator-superset/pull/8490#discussion_r342163689
 
 

 ##########
 File path: superset/config.py
 ##########
 @@ -699,6 +700,7 @@ class CeleryConfig(object):
 # a dedicated period of time to allow chart producers to update their charts before
 # mass migrating all charts to use the [start, end) interval.
 SIP_15_ENABLED = False
+SIP_15_GRACE_PERIOD_END: Optional[date] = None  # exclusive
 SIP_15_DEFAULT_TIME_RANGE_ENDPOINTS = ["unknown", "inclusive"]
 SIP_15_TOAST_MESSAGE = 'Action Required: Preview then save your chart using the new time range endpoints <a href="{url}" class="alert-link">here</a>.'
 
 Review comment:
   should we add the grace period to the toast to say when the action is required by?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org