You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Mike Kienenberger <mk...@gmail.com> on 2005/10/03 17:28:08 UTC
Share files duplicated?
Should there be multiple copies of
org.apache.myfaces.config.MyFacesConfig.class in myfaces-all.jar?
I see three in the jar file I'm currently using. There's two copies
in the 1.1.1RC1 release.
Actually, I'm seeing multiple copies of a few files in the RC1 release
now that I've sorted by filename.
It looks like the stuff in "share" is being duplicated. My guess is
that both tomahawk and impl contain the same "share" files.
That brings to mind a related issue.
If tomahawk requires the use of "share" to work with another JSF
implementation, and myfaces-impl requires the use of "share" to work
as a JSF implementation, won't including both jar files introduce
duplicates as well?
Do we need a myfaces-share.jar file?
Someone on the facelets mailing list brought up the problem:
========================================
OK, here's what I get when I put the tomahawk.jar in my .war file,
everything else is by necessity in the JBoss /server/default/lib:
SEVERE: Error Rendering View
java.lang.ClassCastException: org.apache.myfaces.config.MyfacesConfig
at org.apache.myfaces.config.MyfacesConfig.getCurrentInstance(MyfacesConfig.java:45)
at org.apache.myfaces.renderkit.html.util.JavascriptUtils.isJavascriptAllowed(JavascriptUtils.java:235)
========================================
I guess for now I'll tell him that he needs to put the myfaces files
in the same location.
Re: Share files duplicated?
Posted by Mike Kienenberger <mk...@gmail.com>.
Sure. I created http://issues.apache.org/jira/browse/MYFACES-663 --
Myfaces-all.jar contains two copies of all /share resources
On 10/4/05, Bill Dudney <bd...@mac.com> wrote:
> was there a jira issue for this? if not Mike would you mind opening one?
>
> Thanks!
>
> -bd-
>
> On Oct 3, 2005, at 9:28 AM, Mike Kienenberger wrote:
>
> > Should there be multiple copies of
> > org.apache.myfaces.config.MyFacesConfig.class in myfaces-all.jar?
> >
> > I see three in the jar file I'm currently using. There's two copies
> > in the 1.1.1RC1 release.
> >
> > Actually, I'm seeing multiple copies of a few files in the RC1 release
> > now that I've sorted by filename.
> >
> > It looks like the stuff in "share" is being duplicated. My guess is
> > that both tomahawk and impl contain the same "share" files.
> >
> > That brings to mind a related issue.
> >
> > If tomahawk requires the use of "share" to work with another JSF
> > implementation, and myfaces-impl requires the use of "share" to work
> > as a JSF implementation, won't including both jar files introduce
> > duplicates as well?
> >
> > Do we need a myfaces-share.jar file?
> >
> > Someone on the facelets mailing list brought up the problem:
> >
> > ========================================
> > OK, here's what I get when I put the tomahawk.jar in my .war file,
> > everything else is by necessity in the JBoss /server/default/lib:
> >
> > SEVERE: Error Rendering View
> > java.lang.ClassCastException: org.apache.myfaces.config.MyfacesConfig
> > at org.apache.myfaces.config.MyfacesConfig.getCurrentInstance
> > (MyfacesConfig.java:45)
> > at
> > org.apache.myfaces.renderkit.html.util.JavascriptUtils.isJavascriptAll
> > owed(JavascriptUtils.java:235)
> > ========================================
> >
> > I guess for now I'll tell him that he needs to put the myfaces files
> > in the same location.
> >
>
>
Re: Share files duplicated?
Posted by Bill Dudney <bd...@mac.com>.
was there a jira issue for this? if not Mike would you mind opening one?
Thanks!
-bd-
On Oct 3, 2005, at 9:28 AM, Mike Kienenberger wrote:
> Should there be multiple copies of
> org.apache.myfaces.config.MyFacesConfig.class in myfaces-all.jar?
>
> I see three in the jar file I'm currently using. There's two copies
> in the 1.1.1RC1 release.
>
> Actually, I'm seeing multiple copies of a few files in the RC1 release
> now that I've sorted by filename.
>
> It looks like the stuff in "share" is being duplicated. My guess is
> that both tomahawk and impl contain the same "share" files.
>
> That brings to mind a related issue.
>
> If tomahawk requires the use of "share" to work with another JSF
> implementation, and myfaces-impl requires the use of "share" to work
> as a JSF implementation, won't including both jar files introduce
> duplicates as well?
>
> Do we need a myfaces-share.jar file?
>
> Someone on the facelets mailing list brought up the problem:
>
> ========================================
> OK, here's what I get when I put the tomahawk.jar in my .war file,
> everything else is by necessity in the JBoss /server/default/lib:
>
> SEVERE: Error Rendering View
> java.lang.ClassCastException: org.apache.myfaces.config.MyfacesConfig
> at org.apache.myfaces.config.MyfacesConfig.getCurrentInstance
> (MyfacesConfig.java:45)
> at
> org.apache.myfaces.renderkit.html.util.JavascriptUtils.isJavascriptAll
> owed(JavascriptUtils.java:235)
> ========================================
>
> I guess for now I'll tell him that he needs to put the myfaces files
> in the same location.
>
Re: Share files duplicated?
Posted by Sean Schofield <se...@gmail.com>.
Sorry I don't have time at the moment. Right now I just have time to
catch up on email.
sean
On 10/3/05, Bill Dudney <bd...@mac.com> wrote:
> Hi Mike,
>
> Agreed this should be addressed. Its probably most easily addressed
> with build file magic.
>
> Sean do you have time to tackle this today? If not I can probably get
> some time this afternoon.
>
> I also agree with their workaround. If all jar files are in the same
> place then the class cast should go away (since all classes will come
> from same class loader).
>
> TTFN,
>
> -bd-
>
> On Oct 3, 2005, at 9:28 AM, Mike Kienenberger wrote:
>
> > Should there be multiple copies of
> > org.apache.myfaces.config.MyFacesConfig.class in myfaces-all.jar?
> >
> > I see three in the jar file I'm currently using. There's two copies
> > in the 1.1.1RC1 release.
> >
> > Actually, I'm seeing multiple copies of a few files in the RC1 release
> > now that I've sorted by filename.
> >
> > It looks like the stuff in "share" is being duplicated. My guess is
> > that both tomahawk and impl contain the same "share" files.
> >
> > That brings to mind a related issue.
> >
> > If tomahawk requires the use of "share" to work with another JSF
> > implementation, and myfaces-impl requires the use of "share" to work
> > as a JSF implementation, won't including both jar files introduce
> > duplicates as well?
> >
> > Do we need a myfaces-share.jar file?
> >
> > Someone on the facelets mailing list brought up the problem:
> >
> > ========================================
> > OK, here's what I get when I put the tomahawk.jar in my .war file,
> > everything else is by necessity in the JBoss /server/default/lib:
> >
> > SEVERE: Error Rendering View
> > java.lang.ClassCastException: org.apache.myfaces.config.MyfacesConfig
> > at org.apache.myfaces.config.MyfacesConfig.getCurrentInstance
> > (MyfacesConfig.java:45)
> > at
> > org.apache.myfaces.renderkit.html.util.JavascriptUtils.isJavascriptAll
> > owed(JavascriptUtils.java:235)
> > ========================================
> >
> > I guess for now I'll tell him that he needs to put the myfaces files
> > in the same location.
> >
>
>
Re: Share files duplicated?
Posted by Bill Dudney <bd...@mac.com>.
Hi Mike,
Agreed this should be addressed. Its probably most easily addressed
with build file magic.
Sean do you have time to tackle this today? If not I can probably get
some time this afternoon.
I also agree with their workaround. If all jar files are in the same
place then the class cast should go away (since all classes will come
from same class loader).
TTFN,
-bd-
On Oct 3, 2005, at 9:28 AM, Mike Kienenberger wrote:
> Should there be multiple copies of
> org.apache.myfaces.config.MyFacesConfig.class in myfaces-all.jar?
>
> I see three in the jar file I'm currently using. There's two copies
> in the 1.1.1RC1 release.
>
> Actually, I'm seeing multiple copies of a few files in the RC1 release
> now that I've sorted by filename.
>
> It looks like the stuff in "share" is being duplicated. My guess is
> that both tomahawk and impl contain the same "share" files.
>
> That brings to mind a related issue.
>
> If tomahawk requires the use of "share" to work with another JSF
> implementation, and myfaces-impl requires the use of "share" to work
> as a JSF implementation, won't including both jar files introduce
> duplicates as well?
>
> Do we need a myfaces-share.jar file?
>
> Someone on the facelets mailing list brought up the problem:
>
> ========================================
> OK, here's what I get when I put the tomahawk.jar in my .war file,
> everything else is by necessity in the JBoss /server/default/lib:
>
> SEVERE: Error Rendering View
> java.lang.ClassCastException: org.apache.myfaces.config.MyfacesConfig
> at org.apache.myfaces.config.MyfacesConfig.getCurrentInstance
> (MyfacesConfig.java:45)
> at
> org.apache.myfaces.renderkit.html.util.JavascriptUtils.isJavascriptAll
> owed(JavascriptUtils.java:235)
> ========================================
>
> I guess for now I'll tell him that he needs to put the myfaces files
> in the same location.
>