You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2014/01/20 11:03:00 UTC

svn commit: r1559663 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/connector/Request.java

Author: markt
Date: Mon Jan 20 10:03:00 2014
New Revision: 1559663

URL: http://svn.apache.org/r1559663
Log:
Remove unused code

Modified:
    tomcat/tc7.0.x/trunk/   (props changed)
    tomcat/tc7.0.x/trunk/java/org/apache/catalina/connector/Request.java

Propchange: tomcat/tc7.0.x/trunk/
------------------------------------------------------------------------------
  Merged /tomcat/trunk:r1559662

Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/connector/Request.java
URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/connector/Request.java?rev=1559663&r1=1559662&r2=1559663&view=diff
==============================================================================
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/connector/Request.java (original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/connector/Request.java Mon Jan 20 10:03:00 2014
@@ -203,12 +203,6 @@ public class Request
      */
     protected boolean sslAttributesParsed = false;
 
-    /**
-     * List of read only attributes for this Request.
-     */
-    private final HashMap<String,Object> readOnlyAttributes =
-        new HashMap<String,Object>();
-
 
     /**
      * The preferred Locales associated with this Request.
@@ -1468,12 +1462,6 @@ public class Request
     @Override
     public void removeAttribute(String name) {
         // Remove the specified attribute
-        // Check for read only attribute
-        // requests are per thread so synchronization unnecessary
-        if (readOnlyAttributes.containsKey(name)) {
-            return;
-        }
-
         // Pass special attributes to the native layer
         if (name.startsWith("org.apache.tomcat.")) {
             coyoteRequest.getAttributes().remove(name);
@@ -1521,12 +1509,6 @@ public class Request
         }
 
         // Add or replace the specified attribute
-        // Check for read only attribute
-        // requests are per thread so synchronization unnecessary
-        if (readOnlyAttributes.containsKey(name)) {
-            return;
-        }
-
         // Do the security check before any updates are made
         if (Globals.IS_SECURITY_ENABLED &&
                 name.equals(Globals.SENDFILE_FILENAME_ATTR)) {



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org