You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "mxsm (via GitHub)" <gi...@apache.org> on 2023/02/25 06:44:47 UTC
[GitHub] [incubator-eventmesh] mxsm opened a new pull request, #3268: [ISSUE #3267] Refactor RequestContext
mxsm opened a new pull request, #3268:
URL: https://github.com/apache/incubator-eventmesh/pull/3268
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Fixes #3267
### Motivation
*Explain the content here.*
*Explain why you want to make the changes and what problem you're trying to solve.*
### Modifications
*Refactor RequestContext*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] mxsm commented on pull request #3268: [ISSUE #3267] Refactor RequestContext
Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm commented on PR #3268:
URL: https://github.com/apache/incubator-eventmesh/pull/3268#issuecomment-1445301120
@jonyangx PTAL~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jonyangx commented on a diff in pull request #3268: [ISSUE #3267] Refactor RequestContext
Posted by "jonyangx (via GitHub)" <gi...@apache.org>.
jonyangx commented on code in PR #3268:
URL: https://github.com/apache/incubator-eventmesh/pull/3268#discussion_r1118192886
##########
eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/tcp/common/TcpClient.java:
##########
@@ -176,20 +174,16 @@ protected void send(Package msg) throws Exception {
protected Package io(Package msg, long timeout) throws Exception {
Object key = RequestContext.key(msg);
- CountDownLatch latch = new CountDownLatch(1);
- RequestContext c = RequestContext.context(key, msg, latch);
- if (!contexts.contains(c)) {
- contexts.put(key, c);
+ RequestContext context = RequestContext.context(key, msg);
+ if (!contexts.contains(context)) {
+ contexts.put(key, context);
} else {
if (log.isInfoEnabled()) {
log.info("duplicate key : {}", key);
}
}
send(msg);
- if (!c.getLatch().await(timeout, TimeUnit.MILLISECONDS)) {
- throw new TimeoutException("operation timeout, context.key=" + c.getKey());
- }
- return c.getResponse();
+ return context.getResponse(timeout);
Review Comment:
@mxsm I think original code is better ，its advantages include currency and timeout controller logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jonyangx merged pull request #3268: [ISSUE #3267] Refactor RequestContext
Posted by "jonyangx (via GitHub)" <gi...@apache.org>.
jonyangx merged PR #3268:
URL: https://github.com/apache/incubator-eventmesh/pull/3268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #3268: [ISSUE #3267] Refactor RequestContext
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3268:
URL: https://github.com/apache/incubator-eventmesh/pull/3268#issuecomment-1445019848
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/3268?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3268](https://codecov.io/gh/apache/incubator-eventmesh/pull/3268?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (563c1fd) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/c978891871ad3f5500621e432d47068e205c5810?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c978891) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 563c1fd differs from pull request most recent head 351f321. Consider uploading reports for the commit 351f321 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3268 +/- ##
=========================================
Coverage 13.07% 13.07%
- Complexity 1159 1160 +1
=========================================
Files 550 550
Lines 28765 28749 -16
Branches 2857 2843 -14
=========================================
- Hits 3761 3759 -2
+ Misses 24679 24667 -12
+ Partials 325 323 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/3268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...he/eventmesh/client/tcp/common/RequestContext.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L3RjcC9jb21tb24vUmVxdWVzdENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../apache/eventmesh/client/tcp/common/TcpClient.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L3RjcC9jb21tb24vVGNwQ2xpZW50LmphdmE=) | `14.44% <0.00%> (+0.46%)` | :arrow_up: |
| [...ventmesh/client/grpc/util/EventMeshClientUtil.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L2dycGMvdXRpbC9FdmVudE1lc2hDbGllbnRVdGlsLmphdmE=) | `91.20% <0.00%> (-0.34%)` | :arrow_down: |
| [...rg/apache/eventmesh/runtime/trace/LogExporter.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL3RyYWNlL0xvZ0V4cG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ime/admin/handler/RedirectClientByPathHandler.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvUmVkaXJlY3RDbGllbnRCeVBhdGhIYW5kbGVyLmphdmE=) | `84.78% <0.00%> (ø)` | |
| [...e/admin/handler/RedirectClientByIpPortHandler.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvUmVkaXJlY3RDbGllbnRCeUlwUG9ydEhhbmRsZXIuamF2YQ==) | `31.37% <0.00%> (ø)` | |
| [.../tcp/client/session/push/DownStreamMsgContext.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9zZXNzaW9uL3B1c2gvRG93blN0cmVhbU1zZ0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...l/tcp/client/recommend/EventMeshRecommendImpl.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9yZWNvbW1lbmQvRXZlbnRNZXNoUmVjb21tZW5kSW1wbC5qYXZh) | `0.83% <0.00%> (+<0.01%)` | :arrow_up: |
| [...entmesh/connector/redis/client/RedissonClient.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1yZWRpcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2Nvbm5lY3Rvci9yZWRpcy9jbGllbnQvUmVkaXNzb25DbGllbnQuamF2YQ==) | `52.27% <0.00%> (+6.81%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jonyangx commented on a diff in pull request #3268: [ISSUE #3267] Refactor RequestContext
Posted by "jonyangx (via GitHub)" <gi...@apache.org>.
jonyangx commented on code in PR #3268:
URL: https://github.com/apache/incubator-eventmesh/pull/3268#discussion_r1118008884
##########
eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/tcp/common/TcpClient.java:
##########
@@ -176,20 +174,16 @@ protected void send(Package msg) throws Exception {
protected Package io(Package msg, long timeout) throws Exception {
Object key = RequestContext.key(msg);
- CountDownLatch latch = new CountDownLatch(1);
- RequestContext c = RequestContext.context(key, msg, latch);
- if (!contexts.contains(c)) {
- contexts.put(key, c);
+ RequestContext context = RequestContext.context(key, msg);
+ if (!contexts.contains(context)) {
+ contexts.put(key, context);
} else {
if (log.isInfoEnabled()) {
log.info("duplicate key : {}", key);
}
}
send(msg);
- if (!c.getLatch().await(timeout, TimeUnit.MILLISECONDS)) {
- throw new TimeoutException("operation timeout, context.key=" + c.getKey());
- }
- return c.getResponse();
+ return context.getResponse(timeout);
Review Comment:
Where execute supplyAsync with CompletableFuture？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org