You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Knut Anders Hatlen (JIRA)" <ji...@apache.org> on 2006/11/04 21:12:17 UTC
[jira] Updated: (DERBY-2047) TestDataSourceFactory doesn't work
correctly outside the old harness
[ http://issues.apache.org/jira/browse/DERBY-2047?page=all ]
Knut Anders Hatlen updated DERBY-2047:
--------------------------------------
Attachment: derby-2047.diff
derby-2047.stat
The attached patch (derby-2047.diff) makes TestDataSourceFactory
independent of TestUtil. Description of the patch:
* Two new methods in JDBCClient: getConnectionPoolDataSourceClassName()
and getXADataSourceClassName()
* JDBCClient now returns correct class names for JDBC 4.0 data sources
* TestDataSourceFactory uses the methods in JDBCClient instead of
TestUtil to create data sources.
* The methods in TestDataSourceFactory now throw exceptions
(ClassNotFoundException, IllegalAccessException, etc.) instead of
printing them.
* Since TestConfiguration.getConnection() uses data sources in some
setups, it had to be modified to handle the new exceptions thrown by
TestDataSourceFactory.
* The following tests (all part of the jdbc4 test suite) used
TestDataSourceFactory and needed to handle the new exceptions:
ClosedObjectTest, VerifySignatures, StatementEventsTest, XA40Test,
DataSourceTest, DataSourceTest.
I have run the full JUnit suite and the jdbc40 suite under the embedded and
DerbyNet frameworks and didn't see any problem related to the patch. Please
review. Thanks.
> TestDataSourceFactory doesn't work correctly outside the old harness
> --------------------------------------------------------------------
>
> Key: DERBY-2047
> URL: http://issues.apache.org/jira/browse/DERBY-2047
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Knut Anders Hatlen
> Assigned To: Knut Anders Hatlen
> Attachments: derby-2047.diff, derby-2047.stat
>
>
> TestDataSourceFactory uses TestUtil to create DataSource, ConnectionPoolDataSource and XADataSource objects. TestUtil needs to run in the old harness in order to detect which framework it is running under, so it will create embedded data sources for all JUnit tests that are run outside the old harness.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira