You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by pu...@apache.org on 2014/09/19 01:24:39 UTC
[1/2] git commit: CB-7357 Adds missing 'capability' element to
phone's appxmanifest.
Repository: cordova-plugin-contacts
Updated Branches:
refs/heads/master 17a5ced70 -> c15a15e95
CB-7357 Adds missing 'capability' element to phone's appxmanifest.
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/commit/42cd509a
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/tree/42cd509a
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/diff/42cd509a
Branch: refs/heads/master
Commit: 42cd509a6c5d8a68ea4151ca23073a710609a8b8
Parents: 10bae15
Author: Vladimir Kotikov <v-...@microsoft.com>
Authored: Thu Aug 21 16:08:03 2014 +0400
Committer: Vladimir Kotikov <v-...@microsoft.com>
Committed: Thu Aug 21 16:27:06 2014 +0400
----------------------------------------------------------------------
plugin.xml | 3 +++
src/windows/ContactProxy.js | 8 ++++----
2 files changed, 7 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/blob/42cd509a/plugin.xml
----------------------------------------------------------------------
diff --git a/plugin.xml b/plugin.xml
index f54f80f..4fd8cbd 100644
--- a/plugin.xml
+++ b/plugin.xml
@@ -225,6 +225,9 @@
<js-module src="src/windows/ContactProxy.js" name="ContactProxy">
<merges target="" />
</js-module>
+ <config-file target="package.phone.appxmanifest" parent="/Package/Capabilities">
+ <m3:Capability Name="contacts" />
+ </config-file>
</platform>
</plugin>
http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/blob/42cd509a/src/windows/ContactProxy.js
----------------------------------------------------------------------
diff --git a/src/windows/ContactProxy.js b/src/windows/ContactProxy.js
index 455ff53..0067150 100644
--- a/src/windows/ContactProxy.js
+++ b/src/windows/ContactProxy.js
@@ -155,10 +155,10 @@ module.exports = {
contactStore.getContactAsync(contact.id).done(function(con) {
win(convertToContact(con));
}, function() {
- fail(new ContactError(ContactError.PENDING_OPERATION_ERROR));
+ fail(new ContactError(ContactError.UNKNOWN_ERROR));
});
}, function () {
- fail(new ContactError(ContactError.PENDING_OPERATION_ERROR));
+ fail(new ContactError(ContactError.UNKNOWN_ERROR));
});
});
},
@@ -208,10 +208,10 @@ module.exports = {
}
win(result);
}, function() {
- fail(new ContactError(ContactError.PENDING_OPERATION_ERROR));
+ fail(new ContactError(ContactError.UNKNOWN_ERROR));
});
}, function() {
- fail(new ContactError(ContactError.PENDING_OPERATION_ERROR));
+ fail(new ContactError(ContactError.UNKNOWN_ERROR));
});
}
};
[2/2] git commit: Merge branch 'CB-7357' of
https://github.com/MSOpenTech/cordova-plugin-contacts
Posted by pu...@apache.org.
Merge branch 'CB-7357' of https://github.com/MSOpenTech/cordova-plugin-contacts
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/commit/c15a15e9
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/tree/c15a15e9
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/diff/c15a15e9
Branch: refs/heads/master
Commit: c15a15e95b12f56a3a3a367a078bd7accd0c6456
Parents: 17a5ced 42cd509
Author: Jesse MacFadyen <pu...@gmail.com>
Authored: Thu Sep 18 16:23:30 2014 -0700
Committer: Jesse MacFadyen <pu...@gmail.com>
Committed: Thu Sep 18 16:23:30 2014 -0700
----------------------------------------------------------------------
plugin.xml | 3 +++
src/windows/ContactProxy.js | 8 ++++----
2 files changed, 7 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/blob/c15a15e9/plugin.xml
----------------------------------------------------------------------