[GitHub] [spark] gengliangwang commented on a change in pull request #24900: [SPARK-28089][SQL] File source v2: support reading output of file streaming Sink

[GitBox <gi...@apache.org>]

gengliangwang commented on a change in pull request #24900: [SPARK-28089][SQL] File source v2: support reading output of file streaming Sink
URL: https://github.com/apache/spark/pull/24900#discussion_r294739873
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingDeduplicationSuite.scala
 ##########
 @@ -197,32 +197,30 @@ class StreamingDeduplicationSuite extends StateStoreMetricsTest {
   }
 
   test("deduplicate with file sink") {
-    withSQLConf(SQLConf.USE_V1_SOURCE_READER_LIST.key -> "parquet") {
-      withTempDir { output =>
-        withTempDir { checkpointDir =>
-          val outputPath = output.getAbsolutePath
-          val inputData = MemoryStream[String]
-          val result = inputData.toDS().dropDuplicates()
-          val q = result.writeStream
-            .format("parquet")
-            .outputMode(Append)
-            .option("checkpointLocation", checkpointDir.getPath)
-            .start(outputPath)
-          try {
-            inputData.addData("a")
-            q.processAllAvailable()
-            checkDataset(spark.read.parquet(outputPath).as[String], "a")
-
-            inputData.addData("a") // Dropped
-            q.processAllAvailable()
-            checkDataset(spark.read.parquet(outputPath).as[String], "a")
-
-            inputData.addData("b")
-            q.processAllAvailable()
-            checkDataset(spark.read.parquet(outputPath).as[String], "a", "b")
-          } finally {
-            q.stop()
-          }
+    withTempDir { output =>
 
 Review comment:
   remove `withSQLConf`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org