You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/10/21 02:09:34 UTC
[GitHub] [solr] jebnix opened a new pull request, #1098: Add a reference for the S3BackupRepository for the supported backup r…
jebnix opened a new pull request, #1098:
URL: https://github.com/apache/solr/pull/1098
…epositories
https://issues.apache.org/jira/browse/SOLR-XXXXX
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
While reading the page someone can think that there is no support for some `S3BackupRepository`.
# Solution
Referencing
# Tests
No
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] jebnix commented on pull request #1098: Add a reference for the S3BackupRepository for the supported backup r…
Posted by GitBox <gi...@apache.org>.
jebnix commented on PR #1098:
URL: https://github.com/apache/solr/pull/1098#issuecomment-1288202630
@risdenk @epugh @janhoy Can you help me pull off an explanation for what are snapshots, so I'll be able to add this so https://solr.apache.org/guide/solr/latest/getting-started/solr-glossary.html#SolrGlossary-S? I think that's necessary...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh merged pull request #1098: Add a reference for the S3BackupRepository for the supported backup r…
Posted by GitBox <gi...@apache.org>.
epugh merged PR #1098:
URL: https://github.com/apache/solr/pull/1098
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #1098: Add a reference for the S3BackupRepository for the supported backup r…
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #1098:
URL: https://github.com/apache/solr/pull/1098#issuecomment-1287144747
>
> @epugh I also think that there should be better clarification as to what are snapshots, and what is the difference between snapshot and backup (with some help here I can add this in a separate PR)
I'd love to see that. I honestly don't know the difference either!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] jebnix commented on a diff in pull request #1098: Add a reference for the S3BackupRepository for the supported backup r…
Posted by GitBox <gi...@apache.org>.
jebnix commented on code in PR #1098:
URL: https://github.com/apache/solr/pull/1098#discussion_r1001972100
##########
solr/solr-ref-guide/modules/deployment-guide/pages/backup-restore.adoc:
##########
@@ -353,7 +353,7 @@ Request ID to track this action which will be processed asynchronously.
Solr provides a repository abstraction to allow users to backup and restore their data to a variety of different storage systems.
For example, a Solr cluster running on a local filesystem (e.g., EXT3) can store backup data on the same disk, on a remote network-mounted drive, in HDFS, or even in some popular "cloud storage" providers, depending on the 'repository' implementation chosen.
-Solr offers three different repository implementations out of the box (`LocalFileSystemRepository`, `HdfsBackupRepository`, and `GCSBackupRepository`), and allows users to create plugins for their own storage systems as needed.
+Solr offers four different repository implementations out of the box (`LocalFileSystemRepository`, `HdfsBackupRepository`, `GCSBackupRepository` and `S3BackupRepository`), and allows users to create plugins for their own storage systems as needed.
Review Comment:
Good idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1098: Add a reference for the S3BackupRepository for the supported backup r…
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1098:
URL: https://github.com/apache/solr/pull/1098#issuecomment-1287199755
> Any help on the subject with a brief explanation?
So few suggestions about finding out how/why/what explanations in general:
* Search jira https://issues.apache.org/jira/issues/?jql=project%20%3D%20SOLR
* usually will find a ticket or few with the implementation details which explain what/how/why potentially
* search solr-user or solr-dev mailing lists - https://solr.apache.org/community.html#mailing-lists-chat
If those two fail - post a new question to solr-user OR solr-dev mailing list (avoid cross posting) and will at least get more eyes on the question.
for snapshot/backup specifically - I have my own definition that I'm not sure matches what Solr is.
* snapshot in my head = point in time version of something. N number of snapshots are kept and can be restored.
* backup in my head = copy of point in time something. so the act of literally copying bits to a new place. usually you backup a snapshot.
now idk if that is how Solr uses the terminology (I mix up different projects all the time) so would be good to double check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on a diff in pull request #1098: Add a reference for the S3BackupRepository for the supported backup r…
Posted by GitBox <gi...@apache.org>.
epugh commented on code in PR #1098:
URL: https://github.com/apache/solr/pull/1098#discussion_r1001944246
##########
solr/solr-ref-guide/modules/deployment-guide/pages/backup-restore.adoc:
##########
@@ -353,7 +353,7 @@ Request ID to track this action which will be processed asynchronously.
Solr provides a repository abstraction to allow users to backup and restore their data to a variety of different storage systems.
For example, a Solr cluster running on a local filesystem (e.g., EXT3) can store backup data on the same disk, on a remote network-mounted drive, in HDFS, or even in some popular "cloud storage" providers, depending on the 'repository' implementation chosen.
-Solr offers three different repository implementations out of the box (`LocalFileSystemRepository`, `HdfsBackupRepository`, and `GCSBackupRepository`), and allows users to create plugins for their own storage systems as needed.
+Solr offers four different repository implementations out of the box (`LocalFileSystemRepository`, `HdfsBackupRepository`, `GCSBackupRepository` and `S3BackupRepository`), and allows users to create plugins for their own storage systems as needed.
Review Comment:
Nice! How about one change and I'll click merge. Let's go with `Solr offers multiple different`, cause otherwise we'll soon have to update this to say `five` ;-) This is really greate fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] jebnix commented on pull request #1098: Add a reference for the S3BackupRepository for the supported backup r…
Posted by GitBox <gi...@apache.org>.
jebnix commented on PR #1098:
URL: https://github.com/apache/solr/pull/1098#issuecomment-1287251926
> * snapshot in my head = point in time version of something. N number of snapshots are kept and can be restored
@risdenk So snapshots are logical only? Or they are being copied locally to some directory? How do they get created?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] jebnix commented on pull request #1098: Add a reference for the S3BackupRepository for the supported backup r…
Posted by GitBox <gi...@apache.org>.
jebnix commented on PR #1098:
URL: https://github.com/apache/solr/pull/1098#issuecomment-1287176439
> >
>
> > @epugh I also think that there should be better clarification as to what are snapshots, and what is the difference between snapshot and backup (with some help here I can add this in a separate PR)
>
> I'd love to see that. I honestly don't know the difference either!
That's indeed problematic. Any help on the subject with a brief explanation? @HoustonPutman @risdenk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1098: Add a reference for the S3BackupRepository for the supported backup r…
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1098:
URL: https://github.com/apache/solr/pull/1098#issuecomment-1288259247
@jebnix what have you found in your research? its much easier for you to propose something instead of just waiting for others to come up with an answer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] jebnix commented on pull request #1098: Add a reference for the S3BackupRepository for the supported backup r…
Posted by GitBox <gi...@apache.org>.
jebnix commented on PR #1098:
URL: https://github.com/apache/solr/pull/1098#issuecomment-1286366273
@epugh I also think that there should be better clarification as to what are snapshots, and what is the difference between snapshot and backup (with some help here I can add this in a separate PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org