You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/02 11:12:22 UTC
[GitHub] [apisix-dashboard] juzhiyuan opened a new pull request #957: fix: use correct method to get object's length
juzhiyuan opened a new pull request #957:
URL: https://github.com/apache/apisix-dashboard/pull/957
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
fix https://github.com/apache/apisix-dashboard/issues/956
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #957: fix: use correct method to get object's length
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #957:
URL: https://github.com/apache/apisix-dashboard/pull/957#issuecomment-737164338
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/957?src=pr&el=h1) Report
> Merging [#957](https://codecov.io/gh/apache/apisix-dashboard/pull/957?src=pr&el=desc) (b5e7463) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/17ad69b5ecfa80b55550d35d68681f55c84f5274?el=desc) (17ad69b) will **increase** coverage by `0.07%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/957?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #957 +/- ##
==========================================
+ Coverage 43.41% 43.49% +0.07%
==========================================
Files 18 18
Lines 1299 1299
==========================================
+ Hits 564 565 +1
+ Misses 643 642 -1
Partials 92 92
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/957?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/957/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `79.22% <0.00%> (+0.64%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/957?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/957?src=pr&el=footer). Last update [17ad69b...b5e7463](https://codecov.io/gh/apache/apisix-dashboard/pull/957?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen merged pull request #957: fix: use correct method to get object's length
Posted by GitBox <gi...@apache.org>.
nic-chen merged pull request #957:
URL: https://github.com/apache/apisix-dashboard/pull/957
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org