[GitHub] [spark] jiangxb1987 commented on issue #24497: [SPARK-27630][CORE] Properly handle task end events from completed stages

[GitBox <gi...@apache.org>]

jiangxb1987 commented on issue #24497: [SPARK-27630][CORE] Properly handle task end events from completed stages
URL: https://github.com/apache/spark/pull/24497#issuecomment-497479838
 
 
   > Just skimming through, would it make sense to make a local case class that is StageAttempt to replace (stageId, stageAttemptId) and rename some of the maps to be stageAttempt.... rather than stageId? More for readability than anything.
   
   +1 Maybe we can extend the `ContextBarrierId`, it was not designed for general purpose but it seems to also fit in here (maybe just rename the class to a proper name)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org