You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kibble.apache.org by GitBox <gi...@apache.org> on 2020/12/13 13:27:00 UTC
[GitHub] [kibble] turbaszek opened a new pull request #120: Improve code quality of scanners
turbaszek opened a new pull request #120:
URL: https://github.com/apache/kibble/pull/120
This PR replaces cameleCase with snake_case, removes some unused
variables and adds some that in some cases may result in run time error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] turbaszek merged pull request #120: Improve code quality of scanners
Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #120:
URL: https://github.com/apache/kibble/pull/120
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] turbaszek commented on pull request #120: Improve code quality of scanners
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #120:
URL: https://github.com/apache/kibble/pull/120#issuecomment-744007754
@michalslowikowski00 this one may help with #90
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] michalslowikowski00 commented on pull request #120: Improve code quality of scanners
Posted by GitBox <gi...@apache.org>.
michalslowikowski00 commented on pull request #120:
URL: https://github.com/apache/kibble/pull/120#issuecomment-744173746
Thx I will in the free time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] turbaszek commented on a change in pull request #120: Improve code quality of scanners
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #120:
URL: https://github.com/apache/kibble/pull/120#discussion_r541925765
##########
File path: kibble/scanners/scanners/travis.py
##########
@@ -195,50 +188,49 @@ def run(self):
self.block.release()
return
self.block.release()
- if not scanJob(self.KibbleBit, self.source, job, self.token, self.tld):
- self.KibbleBit.pprint("[%s] This borked, trying another one" % job)
- badOnes += 1
- if badOnes > 100:
- self.KibbleBit.pprint("Too many errors, bailing!")
+ if not scan_job(self.kibble_bit, self.source, job, self.token, self.tld):
+ self.kibble_bit.pprint("[%s] This borked, trying another one" % job)
+ bad_ones += 1
+ if bad_ones > 100:
+ self.kibble_bit.pprint("Too many errors, bailing!")
self.source["steps"]["travis"] = {
"time": time.time(),
"status": "Too many errors while parsing at "
+ time.strftime("%Y/%m/%d %H:%M:%S", time.gmtime(time.time())),
"running": False,
"good": False,
}
- self.KibbleBit.updateSource(self.source)
+ self.kibble_bit.update_source(self.source)
return
else:
- badOnes = 0
+ bad_ones = 0
-def sclan(KibbleBit, source):
+def scan(kibble_bit, source):
Review comment:
This should fix the scanner 👀
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org