[jira] [Commented] (SHINDIG-1627) When running with a non-root context, RPC calls are still being made to /rpc unless overridden with config

["jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHINDIG-1627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125291#comment-13125291 ] 

jiraposter@reviews.apache.org commented on SHINDIG-1627:
--------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2348/
-----------------------------------------------------------

Review request for shindig.


Summary
-------

Should now be using the defaults as they were injected if not provided explicitly through the common container config.


This addresses bug SHINDIG-1627.
    https://issues.apache.org/jira/browse/SHINDIG-1627


Diffs
-----

  http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/service.js 1181802 

Diff: https://reviews.apache.org/r/2348/diff


Testing
-------

Doug, Li, or anyone else interested...

I know it's been a while coming, but I've been really busy.   Could you please test this small patch to see if it fixes the problem you guys were having?


Thanks,

Dan


                
> When running with a non-root context, RPC calls are still being made to /rpc unless overridden with config
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1627
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1627
>             Project: Shindig
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Doug Davies
>
> From Dan Dumont:
> The problem before is that '/rpc' was always registered.  Always.  It just 
> never stuck because the service had already been registered.
> My change (SHINDIG-1569) changed that so it could be overridden by the config (necessary 
> for cross domain container loading).
> Now /rpc is taking hold, overriding the previously set service.  I didn't 
> see this because we typically do not deploy on non-root contexts.
> So the workaround is to specify the path in the config, but I think there 
> should be a JIRA for this so that we don't hardcode the default '/rpc' but 
> instead somehow use the value that was used to register the service first.
> Or not register the service at all if the path/host has not been specified 
> in the config.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira