[jira] [Commented] (KAFKA-404) When using chroot path, create chroot on startup if it doesn't exist

["Guozhang Wang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829263#comment-13829263 ] 

Guozhang Wang commented on KAFKA-404:
-------------------------------------

Thanks for the patch, a few comments:

1. val parts = chroot.split("/").drop(1) // Do you need to drop(1) since you are spliting from chroot, not zkConnect string?

2. Could you try to reuse ZkUtil.createPersistentPath ?

3. Could you rename xxTmp to xxForChrootCreation?

4. info("Created zookeeper path "+path) // Might be better just having one info logging at the end of the loop?

Guozhang

> When using chroot path, create chroot on startup if it doesn't exist
> --------------------------------------------------------------------
>
>                 Key: KAFKA-404
>                 URL: https://issues.apache.org/jira/browse/KAFKA-404
>             Project: Kafka
>          Issue Type: Improvement
>    Affects Versions: 0.8.1
>         Environment: CentOS 5.5, Linux 2.6.18-194.32.1.el5 x86_64 GNU/Linux
>            Reporter: Jonathan Creasy
>              Labels: newbie, patch
>             Fix For: 0.8.1
>
>         Attachments: KAFKA-404-0.7.1.patch, KAFKA-404-0.8.patch, KAFKA-404-auto-create-zookeeper-chroot-on-start-up-i.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)