You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/09/25 17:04:20 UTC
Review Request 62548: Reorganized and updated the contribution
guidelines.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62548/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, and Vinod Kone.
Bugs: MESOS-564
https://issues.apache.org/jira/browse/MESOS-564
Repository: mesos
Description
-------
Reorganized and updated the contribution guidelines.
Diffs
-----
docs/home.md f9b35e3e8f9af024a58760c345931d73a83654ff
docs/newbie-guide.md e9f2aaac1bb986120f34b1d006e3a2f5eb2779ff
docs/reopening-reviews.md fe5046830bbdf28fcc2377ffa5792549920afbc8
docs/reporting-a-bug.md a7e372c1f0d3a34a06244aecb1dfeef7356b8928
docs/submitting-a-patch.md ffc6e561b8721b8849ef6025c15936ea712d3bfa
site/source/community.html.md f56131fedb935ff695206948e16252c62ae0f36a
Diff: https://reviews.apache.org/r/62548/diff/1/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 62548: Reorganized and updated the contribution
guidelines.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62548/#review186153
-----------------------------------------------------------
PASS: Mesos patch 62548 was successfully built and tested.
Reviews applied: `['62548']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62548
- Mesos Reviewbot Windows
On Sept. 25, 2017, 6:02 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62548/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2017, 6:02 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-564
> https://issues.apache.org/jira/browse/MESOS-564
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Reorganized and updated the contribution guidelines.
>
>
> Diffs
> -----
>
> docs/home.md f9b35e3e8f9af024a58760c345931d73a83654ff
> docs/newbie-guide.md e9f2aaac1bb986120f34b1d006e3a2f5eb2779ff
> docs/reopening-reviews.md fe5046830bbdf28fcc2377ffa5792549920afbc8
> docs/reporting-a-bug.md a7e372c1f0d3a34a06244aecb1dfeef7356b8928
> docs/submitting-a-patch.md ffc6e561b8721b8849ef6025c15936ea712d3bfa
> site/source/community.html.md f56131fedb935ff695206948e16252c62ae0f36a
>
>
> Diff: https://reviews.apache.org/r/62548/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 62548: Reorganized and updated the contribution
guidelines.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62548/#review188681
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Oct. 18, 2017, 7:36 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62548/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2017, 7:36 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-564
> https://issues.apache.org/jira/browse/MESOS-564
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch splits the contribution guidelines into two parts:
> a beginner contribution guide, and an advanced guide. Some files
> are also renamed, and links updated.
>
>
> Diffs
> -----
>
> docs/beginner-contribution.md PRE-CREATION
> docs/home.md 6a6bd736367505e00c27e5ecd37a68c8e01efe10
> docs/newbie-guide.md e9f2aaac1bb986120f34b1d006e3a2f5eb2779ff
> docs/reopening-reviews.md fe5046830bbdf28fcc2377ffa5792549920afbc8
> docs/reporting-a-bug.md a7e372c1f0d3a34a06244aecb1dfeef7356b8928
> docs/submitting-a-patch.md ffc6e561b8721b8849ef6025c15936ea712d3bfa
> site/source/community.html.md f56131fedb935ff695206948e16252c62ae0f36a
>
>
> Diff: https://reviews.apache.org/r/62548/diff/5/
>
>
> Testing
> -------
>
> The updated docs were examined using GitHub's markdown viewer.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 62548: Reorganized and updated the contribution
guidelines.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62548/
-----------------------------------------------------------
(Updated Oct. 18, 2017, 7:36 p.m.)
Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, and Vinod Kone.
Bugs: MESOS-564
https://issues.apache.org/jira/browse/MESOS-564
Repository: mesos
Description (updated)
-------
This patch splits the contribution guidelines into two parts:
a beginner contribution guide, and an advanced guide. Some files
are also renamed, and links updated.
Diffs
-----
docs/beginner-contribution.md PRE-CREATION
docs/home.md 6a6bd736367505e00c27e5ecd37a68c8e01efe10
docs/newbie-guide.md e9f2aaac1bb986120f34b1d006e3a2f5eb2779ff
docs/reopening-reviews.md fe5046830bbdf28fcc2377ffa5792549920afbc8
docs/reporting-a-bug.md a7e372c1f0d3a34a06244aecb1dfeef7356b8928
docs/submitting-a-patch.md ffc6e561b8721b8849ef6025c15936ea712d3bfa
site/source/community.html.md f56131fedb935ff695206948e16252c62ae0f36a
Diff: https://reviews.apache.org/r/62548/diff/5/
Testing (updated)
-------
The updated docs were examined using GitHub's markdown viewer.
Thanks,
Greg Mann
Re: Review Request 62548: Reorganized and updated the contribution
guidelines.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62548/
-----------------------------------------------------------
(Updated Oct. 18, 2017, 7:35 p.m.)
Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, and Vinod Kone.
Bugs: MESOS-564
https://issues.apache.org/jira/browse/MESOS-564
Repository: mesos
Description
-------
Reorganized and updated the contribution guidelines.
Diffs (updated)
-----
docs/beginner-contribution.md PRE-CREATION
docs/home.md 6a6bd736367505e00c27e5ecd37a68c8e01efe10
docs/newbie-guide.md e9f2aaac1bb986120f34b1d006e3a2f5eb2779ff
docs/reopening-reviews.md fe5046830bbdf28fcc2377ffa5792549920afbc8
docs/reporting-a-bug.md a7e372c1f0d3a34a06244aecb1dfeef7356b8928
docs/submitting-a-patch.md ffc6e561b8721b8849ef6025c15936ea712d3bfa
site/source/community.html.md f56131fedb935ff695206948e16252c62ae0f36a
Diff: https://reviews.apache.org/r/62548/diff/5/
Changes: https://reviews.apache.org/r/62548/diff/4-5/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 62548: Reorganized and updated the contribution
guidelines.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62548/
-----------------------------------------------------------
(Updated Oct. 18, 2017, 7:23 p.m.)
Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, and Vinod Kone.
Bugs: MESOS-564
https://issues.apache.org/jira/browse/MESOS-564
Repository: mesos
Description
-------
Reorganized and updated the contribution guidelines.
Diffs (updated)
-----
docs/beginner-contribution.md PRE-CREATION
docs/home.md 6a6bd736367505e00c27e5ecd37a68c8e01efe10
docs/newbie-guide.md e9f2aaac1bb986120f34b1d006e3a2f5eb2779ff
docs/reopening-reviews.md fe5046830bbdf28fcc2377ffa5792549920afbc8
docs/reporting-a-bug.md a7e372c1f0d3a34a06244aecb1dfeef7356b8928
docs/submitting-a-patch.md ffc6e561b8721b8849ef6025c15936ea712d3bfa
site/source/community.html.md f56131fedb935ff695206948e16252c62ae0f36a
Diff: https://reviews.apache.org/r/62548/diff/4/
Changes: https://reviews.apache.org/r/62548/diff/3-4/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 62548: Reorganized and updated the contribution
guidelines.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62548/#review187874
-----------------------------------------------------------
FAIL: Some Mesos tests failed.
Reviews applied: `['62548']`
Failed command: `C:\mesos\src\mesos-tests.exe --verbose --gtest_filter="-ContentType/MasterAPITest.EventAuthorizationFiltering/1"`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62548
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62548/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.UnauthorizedRequest/0 (304 ms)
[ RUN ] Endpoint/SlaveEndpointTest.UnauthorizedRequest/1
[ OK ] Endpoint/SlaveEndpointTest.UnauthorizedRequest/1 (293 ms)
[ RUN ] Endpoint/SlaveEndpointTest.UnauthorizedRequest/2
[ OK ] Endpoint/SlaveEndpointTest.UnauthorizedRequest/2 (281 ms)
[ RUN ] Endpoint/SlaveEndpointTest.NoAuthorizer/0
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/0 (296 ms)
[ RUN ] Endpoint/SlaveEndpointTest.NoAuthorizer/1
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/1 (341 ms)
[ RUN ] Endpoint/SlaveEndpointTest.NoAuthorizer/2
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (286 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (3025 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (133 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (155 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (339 ms total)
[----------] Global test environment tear-down
[==========] 723 tests from 73 test cases ran. (371412 ms total)
[ PASSED ] 722 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] MesosContainerizer/DefaultExecutorTest.ROOT_ContainerStatusForTask/0, where GetParam() = "mesos"
1 FAILED TEST
YOU HAVE 165 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62548/logs/mesos-tests-stderr.log):
```
I1012 21:26:53.156424 52204 containerizer.cpp:648] Recovering containerizer
I1012 21:26:53.167423 48364 provisioner.cpp:416] Provisioner recovery complete
I1012 21:26:53.169423 51620 slave.cpp:6310] Finished recovery
I1012 21:26:53.195425 42280 http.cpp:1185] HTTP GET for /slave(270)/monitor/statistics.json from 10.3.1.7:56731
I1012 21:26:53.196424 42280 http.cpp:976] Authorizing principal 'test-principal' to GET the '/monitor/statistics.json' endpoint
I1012 21:26:53.245074 47652 slave.cpp:869] Agent terminating
I1012 21:26:53.398926 47652 containerizer.cpp:292] Using isolation { windows/cpu, filesystem/windows, environment_secret }
I1012 21:26:53.400929 47652 provisioner.cpp:255] Using default backend 'copy'
I1012 21:26:53.418929 47652 cluster.cpp:448] Creating default 'local' authorizer
I1012 21:26:53.433930 46208 slave.cpp:254] Mesos agent started on (271)@10.3.1.7:55799
I1012 21:26:53.433930 46208 slave.cpp:255] Flags at startup: --acls="" --appc_simple_discovery_uri_prefix="http://" --appc_store_dir="C:\Users\mesos\AppData\Local\Temp\2\87x5Jp\store\appc" --authenticate_http_readonly="true" --authenticate_http_readwrite="true" --authenticatee="crammd5" --authentication_backoff_factor="1secs" --authorizer="local" --container_disk_watch_interval="15secs" --containerizers="mesos" --credential="C:\Users\mesos\AppData\Local\Temp\2\87x5Jp\credential" --default_role="*" --disk_watch_interval="1mins" --docker="docker" --docker_kill_orphans="true" --docker_registry="https://registry-1.docker.io" --docker_remove_delay="6hrs" --docker_socket="//./pipe/docker_engine" --docker_stop_timeout="0ns" --docker_store_dir="C:\Users\mesos\AppData\Local\Temp\2\87x5Jp\store\docker" --docker_volume_checkpoint_dir="/var/run/mesos/isolators/docker/volume" --enforce_container_disk_quota="false" --executor_registration_timeout="1mins" --executor_reregistration_timeout="2secs" -
-executor_shutdown_grace_period="5secs" --fetcher_cache_dir="C:\Users\mesos\AppData\Local\Temp\2\87x5Jp\fetch" --fetcher_cache_size="2GB" --frameworks_home="" --gc_delay="1weeks" --gc_disk_headroom="0.1" --hadoop_home="" --help="false" --hostname_lookup="true" --http_command_executor="false" --http_credentials="C:\Users\mesos\AppData\Local\Temp\2\87x5Jp\http_credentials" --http_heartbeat_interval="30secs" --initialize_driver_logging="true" --isolation="windows/cpu" --launcher="windows" --launcher_dir="C:\mesos\src" --logbufsecs="0" --logging_level="INFO" --max_completed_executors_per_framework="150" --oversubscribed_resources_interval="15secs" --port="5051" --qos_correction_interval_min="0ns" --quiet="false" --recover="reconnect" --recovery_timeout="15mins" --registration_backoff_factor="10ms" --resources="cpus:2;gpus:0;mem:1024;disk:1024;ports:[31000-32000]" --runtime_dir="C:\Users\mesos\AppData\Local\Temp\2\87x5Jp" --sandbox_directory="C:\mesos\sandbox" --strict="true" --version="
false" --work_dir="C:\Users\mesos\AppData\Local\Temp\2\1dgUFd" --zk_session_timeout="10secs"
I1012 21:26:53.463932 46208 credentials.hpp:86] Loading credential for authentication from 'C:\Users\mesos\AppData\Local\Temp\2\87x5Jp\credential'
I1012 21:26:53.463932 46208 slave.cpp:287] Agent using credential for: test-principal
I1012 21:26:53.463932 46208 credentials.hpp:37] Loading credentials for authentication from 'C:\Users\mesos\AppData\Local\Temp\2\87x5Jp\http_credentials'
I1012 21:26:53.467931 46208 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-agent-readonly'
I1012 21:26:53.478930 46208 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-agent-readwrite'
I1012 21:26:53.486935 46208 slave.cpp:585] Agent resources: [{"name":"cpus","scalar":{"value":2.0},"type":"SCALAR"},{"name":"mem","scalar":{"value":1024.0},"type":"SCALAR"},{"name":"disk","scalar":{"value":1024.0},"type":"SCALAR"},{"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"type":"RANGES"}]
I1012 21:26:53.490936 46208 slave.cpp:593] Agent attributes: [ ]
I1012 21:26:53.490936 46208 slave.cpp:602] Agent hostname: mesos-bld-s2.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I1012 21:26:53.491941 50292 status_update_manager.cpp:177] Pausing sending status updates
I1012 21:26:53.500933 52204 state.cpp:64] Recovering state from 'C:\Users\mesos\AppData\Local\Temp\2\1dgUFd\meta'
I1012 21:26:53.502931 51620 status_update_manager.cpp:203] Recovering status update manager
I1012 21:26:53.502931 40536 containerizer.cpp:648] Recovering containerizer
I1012 21:26:53.512931 50556 provisioner.cpp:416] Provisioner recovery complete
I1012 21:26:53.525564 50292 slave.cpp:6310] Finished recovery
I1012 21:26:53.544570 52204 http.cpp:1185] HTTP GET for /slave(271)/containers from 10.3.1.7:56732
I1012 21:26:53.545570 52204 http.cpp:976] Authorizing principal 'test-principal' to GET the '/containers' endpoint
I1012 21:26:53.564564 50292 slave.cpp:869] Agent terminating
I1012 21:26:54.590319 52092 process.cpp:1068] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Oct. 12, 2017, 6:06 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62548/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2017, 6:06 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-564
> https://issues.apache.org/jira/browse/MESOS-564
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Reorganized and updated the contribution guidelines.
>
>
> Diffs
> -----
>
> docs/home.md 719d1019fbc5830b98e302ca153dc63ce311ca4f
> docs/newbie-guide.md e9f2aaac1bb986120f34b1d006e3a2f5eb2779ff
> docs/reopening-reviews.md fe5046830bbdf28fcc2377ffa5792549920afbc8
> docs/reporting-a-bug.md a7e372c1f0d3a34a06244aecb1dfeef7356b8928
> docs/submitting-a-patch.md ffc6e561b8721b8849ef6025c15936ea712d3bfa
> site/source/community.html.md f56131fedb935ff695206948e16252c62ae0f36a
>
>
> Diff: https://reviews.apache.org/r/62548/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 62548: Reorganized and updated the contribution
guidelines.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62548/#review187931
-----------------------------------------------------------
Bad patch!
Reviews applied: [62548]
Failed command: python support/apply-reviews.py -n -r 62548
Error:
2017-10-13 04:29:16 URL:https://reviews.apache.org/r/62548/diff/raw/ [29054/29054] -> "62548.patch" [1]
error: patch failed: docs/home.md:96
error: docs/home.md: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/19776/console
- Mesos Reviewbot
On Oct. 12, 2017, 6:06 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62548/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2017, 6:06 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-564
> https://issues.apache.org/jira/browse/MESOS-564
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Reorganized and updated the contribution guidelines.
>
>
> Diffs
> -----
>
> docs/home.md 719d1019fbc5830b98e302ca153dc63ce311ca4f
> docs/newbie-guide.md e9f2aaac1bb986120f34b1d006e3a2f5eb2779ff
> docs/reopening-reviews.md fe5046830bbdf28fcc2377ffa5792549920afbc8
> docs/reporting-a-bug.md a7e372c1f0d3a34a06244aecb1dfeef7356b8928
> docs/submitting-a-patch.md ffc6e561b8721b8849ef6025c15936ea712d3bfa
> site/source/community.html.md f56131fedb935ff695206948e16252c62ae0f36a
>
>
> Diff: https://reviews.apache.org/r/62548/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 62548: Reorganized and updated the contribution
guidelines.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Oct. 13, 2017, 12:13 a.m., Vinod Kone wrote:
> > docs/newbie-guide.md
> > Line 72 (original), 60 (patched)
> > <https://reviews.apache.org/r/62548/diff/3/?file=1853565#file1853565line75>
> >
> > We should probably move everything below this to advanced guide.
Good call, will do.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62548/#review187884
-----------------------------------------------------------
On Oct. 12, 2017, 6:06 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62548/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2017, 6:06 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-564
> https://issues.apache.org/jira/browse/MESOS-564
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Reorganized and updated the contribution guidelines.
>
>
> Diffs
> -----
>
> docs/home.md 719d1019fbc5830b98e302ca153dc63ce311ca4f
> docs/newbie-guide.md e9f2aaac1bb986120f34b1d006e3a2f5eb2779ff
> docs/reopening-reviews.md fe5046830bbdf28fcc2377ffa5792549920afbc8
> docs/reporting-a-bug.md a7e372c1f0d3a34a06244aecb1dfeef7356b8928
> docs/submitting-a-patch.md ffc6e561b8721b8849ef6025c15936ea712d3bfa
> site/source/community.html.md f56131fedb935ff695206948e16252c62ae0f36a
>
>
> Diff: https://reviews.apache.org/r/62548/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 62548: Reorganized and updated the contribution
guidelines.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62548/#review187884
-----------------------------------------------------------
docs/newbie-guide.md
Line 2 (original), 2 (patched)
<https://reviews.apache.org/r/62548/#comment264924>
Can we name this file
"beginner-contribution" to be consistent with "advanced-contribution"
docs/newbie-guide.md
Line 72 (original), 60 (patched)
<https://reviews.apache.org/r/62548/#comment264958>
We should probably move everything below this to advanced guide.
docs/reporting-a-bug.md
Line 2 (original), 2 (patched)
<https://reviews.apache.org/r/62548/#comment264932>
Can you rename the file to "reporting-an-issue"
site/source/community.html.md
Line 22 (original), 22 (patched)
<https://reviews.apache.org/r/62548/#comment264930>
s/new features/fixes and features/
- Vinod Kone
On Oct. 12, 2017, 6:06 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62548/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2017, 6:06 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-564
> https://issues.apache.org/jira/browse/MESOS-564
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Reorganized and updated the contribution guidelines.
>
>
> Diffs
> -----
>
> docs/home.md 719d1019fbc5830b98e302ca153dc63ce311ca4f
> docs/newbie-guide.md e9f2aaac1bb986120f34b1d006e3a2f5eb2779ff
> docs/reopening-reviews.md fe5046830bbdf28fcc2377ffa5792549920afbc8
> docs/reporting-a-bug.md a7e372c1f0d3a34a06244aecb1dfeef7356b8928
> docs/submitting-a-patch.md ffc6e561b8721b8849ef6025c15936ea712d3bfa
> site/source/community.html.md f56131fedb935ff695206948e16252c62ae0f36a
>
>
> Diff: https://reviews.apache.org/r/62548/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 62548: Reorganized and updated the contribution
guidelines.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62548/
-----------------------------------------------------------
(Updated Oct. 12, 2017, 6:06 p.m.)
Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, and Vinod Kone.
Bugs: MESOS-564
https://issues.apache.org/jira/browse/MESOS-564
Repository: mesos
Description
-------
Reorganized and updated the contribution guidelines.
Diffs (updated)
-----
docs/home.md 719d1019fbc5830b98e302ca153dc63ce311ca4f
docs/newbie-guide.md e9f2aaac1bb986120f34b1d006e3a2f5eb2779ff
docs/reopening-reviews.md fe5046830bbdf28fcc2377ffa5792549920afbc8
docs/reporting-a-bug.md a7e372c1f0d3a34a06244aecb1dfeef7356b8928
docs/submitting-a-patch.md ffc6e561b8721b8849ef6025c15936ea712d3bfa
site/source/community.html.md f56131fedb935ff695206948e16252c62ae0f36a
Diff: https://reviews.apache.org/r/62548/diff/3/
Changes: https://reviews.apache.org/r/62548/diff/2-3/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 62548: Reorganized and updated the contribution
guidelines.
Posted by Tom Runyon <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62548/#review186296
-----------------------------------------------------------
I like the idea of adding PR submissions for "trivial" improvements. I would suggest adding some guidelines on what that would mean. Our internal team used to have full code reviews for non-trivial changes vs PRs for trivial changes and eventually we've creeped to having only PRs since its that much easier. Some line in the sand would help people understand the divide, and prevent that line from shifting.
- Tom Runyon
On Sept. 25, 2017, 6:02 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62548/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2017, 6:02 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-564
> https://issues.apache.org/jira/browse/MESOS-564
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Reorganized and updated the contribution guidelines.
>
>
> Diffs
> -----
>
> docs/home.md f9b35e3e8f9af024a58760c345931d73a83654ff
> docs/newbie-guide.md e9f2aaac1bb986120f34b1d006e3a2f5eb2779ff
> docs/reopening-reviews.md fe5046830bbdf28fcc2377ffa5792549920afbc8
> docs/reporting-a-bug.md a7e372c1f0d3a34a06244aecb1dfeef7356b8928
> docs/submitting-a-patch.md ffc6e561b8721b8849ef6025c15936ea712d3bfa
> site/source/community.html.md f56131fedb935ff695206948e16252c62ae0f36a
>
>
> Diff: https://reviews.apache.org/r/62548/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 62548: Reorganized and updated the contribution
guidelines.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62548/#review186161
-----------------------------------------------------------
Patch looks great!
Reviews applied: [62548]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Sept. 25, 2017, 6:02 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62548/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2017, 6:02 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-564
> https://issues.apache.org/jira/browse/MESOS-564
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Reorganized and updated the contribution guidelines.
>
>
> Diffs
> -----
>
> docs/home.md f9b35e3e8f9af024a58760c345931d73a83654ff
> docs/newbie-guide.md e9f2aaac1bb986120f34b1d006e3a2f5eb2779ff
> docs/reopening-reviews.md fe5046830bbdf28fcc2377ffa5792549920afbc8
> docs/reporting-a-bug.md a7e372c1f0d3a34a06244aecb1dfeef7356b8928
> docs/submitting-a-patch.md ffc6e561b8721b8849ef6025c15936ea712d3bfa
> site/source/community.html.md f56131fedb935ff695206948e16252c62ae0f36a
>
>
> Diff: https://reviews.apache.org/r/62548/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 62548: Reorganized and updated the contribution
guidelines.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62548/#review187202
-----------------------------------------------------------
Fix it, then Ship it!
This is fantastic, ship it!
docs/home.md
Lines 98-99 (patched)
<https://reviews.apache.org/r/62548/#comment264102>
Top of the list. +1
docs/newbie-guide.md
Line 37 (original), 26 (patched)
<https://reviews.apache.org/r/62548/#comment264103>
I think you can make the links to Getting Started relative links, like `[Getting Started](getting-started.md)`. The site generation takes care of making the link work, and this will avoid changes to the top-level domain (and me making comments like, "this should be HTTPS!" because everything should always be HTTPS).
docs/newbie-guide.md
Lines 39 (patched)
<https://reviews.apache.org/r/62548/#comment264104>
:D
docs/newbie-guide.md
Line 66 (original), 53 (patched)
<https://reviews.apache.org/r/62548/#comment264105>
I love the link to the YouTube video, that will help people out a lot I think.
I've tried to explain `libprocess` as "it's just like Erlang processes!" but that wasn't a great explanation if they hadn't used Erlang...
docs/submitting-a-patch.md
Line 2 (original), 2 (patched)
<https://reviews.apache.org/r/62548/#comment264101>
I think making this the advanced guide makes a ton more sense. +1
- Andrew Schwartzmeyer
On Sept. 25, 2017, 11:02 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62548/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2017, 11:02 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-564
> https://issues.apache.org/jira/browse/MESOS-564
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Reorganized and updated the contribution guidelines.
>
>
> Diffs
> -----
>
> docs/home.md f9b35e3e8f9af024a58760c345931d73a83654ff
> docs/newbie-guide.md e9f2aaac1bb986120f34b1d006e3a2f5eb2779ff
> docs/reopening-reviews.md fe5046830bbdf28fcc2377ffa5792549920afbc8
> docs/reporting-a-bug.md a7e372c1f0d3a34a06244aecb1dfeef7356b8928
> docs/submitting-a-patch.md ffc6e561b8721b8849ef6025c15936ea712d3bfa
> site/source/community.html.md f56131fedb935ff695206948e16252c62ae0f36a
>
>
> Diff: https://reviews.apache.org/r/62548/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 62548: Reorganized and updated the contribution
guidelines.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62548/
-----------------------------------------------------------
(Updated Sept. 25, 2017, 6:02 p.m.)
Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, and Vinod Kone.
Bugs: MESOS-564
https://issues.apache.org/jira/browse/MESOS-564
Repository: mesos
Description
-------
Reorganized and updated the contribution guidelines.
Diffs (updated)
-----
docs/home.md f9b35e3e8f9af024a58760c345931d73a83654ff
docs/newbie-guide.md e9f2aaac1bb986120f34b1d006e3a2f5eb2779ff
docs/reopening-reviews.md fe5046830bbdf28fcc2377ffa5792549920afbc8
docs/reporting-a-bug.md a7e372c1f0d3a34a06244aecb1dfeef7356b8928
docs/submitting-a-patch.md ffc6e561b8721b8849ef6025c15936ea712d3bfa
site/source/community.html.md f56131fedb935ff695206948e16252c62ae0f36a
Diff: https://reviews.apache.org/r/62548/diff/2/
Changes: https://reviews.apache.org/r/62548/diff/1-2/
Testing
-------
Thanks,
Greg Mann