You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "David Jencks (JIRA)" <ji...@apache.org> on 2010/01/20 09:43:56 UTC
[jira] Created: (GERONIMO-5038) Need to URLEncode temp bundle
location since felix URLDecodes it
Need to URLEncode temp bundle location since felix URLDecodes it
----------------------------------------------------------------
Key: GERONIMO-5038
URL: https://issues.apache.org/jira/browse/GERONIMO-5038
Project: Geronimo
Issue Type: Bug
Security Level: public (Regular issues)
Components: deployment, osgi
Affects Versions: 3.0
Reporter: David Jencks
Assignee: David Jencks
Fix For: 3.0
Today I started having deployment problems because the temporary files had a lot of '+' characters in them which got taken out by felix. I discovered that felix runs URLDecoder.decode(location) on the supplied location of a bundle. To counteract this we have to run URLEncoder.encode(location, "UTF-8") before handing it to felix.
I suggested on the felix dev list that URLDecoder.decode(location, "UTF-8") would be more appropriate per javadoc, but I wonder why something intended for encoding form data in a url is being used for file names. Doesn't URL.encode or File.toURI().toURL() work?
Leaving open in case anyone has an idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-5038) Need to URLEncode temp bundle
location since felix URLDecodes it
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-5038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802748#action_12802748 ]
David Jencks commented on GERONIMO-5038:
----------------------------------------
fixed for now in rev 901105
> Need to URLEncode temp bundle location since felix URLDecodes it
> ----------------------------------------------------------------
>
> Key: GERONIMO-5038
> URL: https://issues.apache.org/jira/browse/GERONIMO-5038
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: deployment, osgi
> Affects Versions: 3.0
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: 3.0
>
>
> Today I started having deployment problems because the temporary files had a lot of '+' characters in them which got taken out by felix. I discovered that felix runs URLDecoder.decode(location) on the supplied location of a bundle. To counteract this we have to run URLEncoder.encode(location, "UTF-8") before handing it to felix.
> I suggested on the felix dev list that URLDecoder.decode(location, "UTF-8") would be more appropriate per javadoc, but I wonder why something intended for encoding form data in a url is being used for file names. Doesn't URL.encode or File.toURI().toURL() work?
> Leaving open in case anyone has an idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (GERONIMO-5038) Need to URLEncode temp bundle
location since felix URLDecodes it
Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-5038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jarek Gawor resolved GERONIMO-5038.
-----------------------------------
Resolution: Fixed
Assignee: Jarek Gawor (was: David Jencks)
Equinox certainly did not like URLEncoded locations. I changed the code instead (part of revision 918677) to do file.toURI().toURL() which properly escapes the spaces, etc. which seems to work well for Felix & Equinox.
> Need to URLEncode temp bundle location since felix URLDecodes it
> ----------------------------------------------------------------
>
> Key: GERONIMO-5038
> URL: https://issues.apache.org/jira/browse/GERONIMO-5038
> Project: Geronimo
> Issue Type: Sub-task
> Security Level: public(Regular issues)
> Components: deployment, osgi
> Affects Versions: 3.0
> Reporter: David Jencks
> Assignee: Jarek Gawor
> Fix For: 3.0
>
>
> Today I started having deployment problems because the temporary files had a lot of '+' characters in them which got taken out by felix. I discovered that felix runs URLDecoder.decode(location) on the supplied location of a bundle. To counteract this we have to run URLEncoder.encode(location, "UTF-8") before handing it to felix.
> I suggested on the felix dev list that URLDecoder.decode(location, "UTF-8") would be more appropriate per javadoc, but I wonder why something intended for encoding form data in a url is being used for file names. Doesn't URL.encode or File.toURI().toURL() work?
> Leaving open in case anyone has an idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (GERONIMO-5038) Need to URLEncode temp bundle
location since felix URLDecodes it
Posted by "Rick McGuire (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-5038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick McGuire closed GERONIMO-5038.
----------------------------------
> Need to URLEncode temp bundle location since felix URLDecodes it
> ----------------------------------------------------------------
>
> Key: GERONIMO-5038
> URL: https://issues.apache.org/jira/browse/GERONIMO-5038
> Project: Geronimo
> Issue Type: Sub-task
> Security Level: public(Regular issues)
> Components: deployment, osgi
> Affects Versions: 3.0
> Reporter: David Jencks
> Assignee: Jarek Gawor
> Fix For: 3.0-M1
>
>
> Today I started having deployment problems because the temporary files had a lot of '+' characters in them which got taken out by felix. I discovered that felix runs URLDecoder.decode(location) on the supplied location of a bundle. To counteract this we have to run URLEncoder.encode(location, "UTF-8") before handing it to felix.
> I suggested on the felix dev list that URLDecoder.decode(location, "UTF-8") would be more appropriate per javadoc, but I wonder why something intended for encoding form data in a url is being used for file names. Doesn't URL.encode or File.toURI().toURL() work?
> Leaving open in case anyone has an idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-5038) Need to URLEncode temp bundle
location since felix URLDecodes it
Posted by "Rick McGuire (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-5038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick McGuire updated GERONIMO-5038:
-----------------------------------
Issue Type: Sub-task (was: Bug)
Parent: GERONIMO-5087
> Need to URLEncode temp bundle location since felix URLDecodes it
> ----------------------------------------------------------------
>
> Key: GERONIMO-5038
> URL: https://issues.apache.org/jira/browse/GERONIMO-5038
> Project: Geronimo
> Issue Type: Sub-task
> Security Level: public(Regular issues)
> Components: deployment, osgi
> Affects Versions: 3.0
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: 3.0
>
>
> Today I started having deployment problems because the temporary files had a lot of '+' characters in them which got taken out by felix. I discovered that felix runs URLDecoder.decode(location) on the supplied location of a bundle. To counteract this we have to run URLEncoder.encode(location, "UTF-8") before handing it to felix.
> I suggested on the felix dev list that URLDecoder.decode(location, "UTF-8") would be more appropriate per javadoc, but I wonder why something intended for encoding form data in a url is being used for file names. Doesn't URL.encode or File.toURI().toURL() work?
> Leaving open in case anyone has an idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-5038) Need to URLEncode temp bundle
location since felix URLDecodes it
Posted by "Rick McGuire (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-5038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick McGuire updated GERONIMO-5038:
-----------------------------------
Fix Version/s: 3.0-M1
(was: 3.0)
> Need to URLEncode temp bundle location since felix URLDecodes it
> ----------------------------------------------------------------
>
> Key: GERONIMO-5038
> URL: https://issues.apache.org/jira/browse/GERONIMO-5038
> Project: Geronimo
> Issue Type: Sub-task
> Security Level: public(Regular issues)
> Components: deployment, osgi
> Affects Versions: 3.0
> Reporter: David Jencks
> Assignee: Jarek Gawor
> Fix For: 3.0-M1
>
>
> Today I started having deployment problems because the temporary files had a lot of '+' characters in them which got taken out by felix. I discovered that felix runs URLDecoder.decode(location) on the supplied location of a bundle. To counteract this we have to run URLEncoder.encode(location, "UTF-8") before handing it to felix.
> I suggested on the felix dev list that URLDecoder.decode(location, "UTF-8") would be more appropriate per javadoc, but I wonder why something intended for encoding form data in a url is being used for file names. Doesn't URL.encode or File.toURI().toURL() work?
> Leaving open in case anyone has an idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-5038) Need to URLEncode temp bundle
location since felix URLDecodes it
Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-5038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838468#action_12838468 ]
Jarek Gawor commented on GERONIMO-5038:
---------------------------------------
Looks like the URLEncoding is creating some problems on Equinox. We might need a different way of creating the url based on the framework the code is running in. But I haven't tested this with latest Equinox version.
> Need to URLEncode temp bundle location since felix URLDecodes it
> ----------------------------------------------------------------
>
> Key: GERONIMO-5038
> URL: https://issues.apache.org/jira/browse/GERONIMO-5038
> Project: Geronimo
> Issue Type: Sub-task
> Security Level: public(Regular issues)
> Components: deployment, osgi
> Affects Versions: 3.0
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: 3.0
>
>
> Today I started having deployment problems because the temporary files had a lot of '+' characters in them which got taken out by felix. I discovered that felix runs URLDecoder.decode(location) on the supplied location of a bundle. To counteract this we have to run URLEncoder.encode(location, "UTF-8") before handing it to felix.
> I suggested on the felix dev list that URLDecoder.decode(location, "UTF-8") would be more appropriate per javadoc, but I wonder why something intended for encoding form data in a url is being used for file names. Doesn't URL.encode or File.toURI().toURL() work?
> Leaving open in case anyone has an idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.