You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/06/02 07:30:48 UTC

[GitHub] [shardingsphere] kimmking opened a new issue #5885: Refactor heartbeat design&implementation

kimmking opened a new issue #5885:
URL: https://github.com/apache/shardingsphere/issues/5885


   ## Background
   1. After our discussion, heartbeat doesn't only be used by proxy, and jdbc too. So we should move and promote it to control-panel and refered by both proxy&jdbc.
   2. And as we know, some datasource pool libraries support the heartbeat feature, just like the popular druid & hikari, then we need consider heartbeat module need integrate with those or not.
   3. Heartbeat module is designed to control the heartbeat progress and gather node state. The physical call between proxy/jdbc and mysql nodes should be directly invoke by a datasource of proxy/jdbc via a common function , instead of proxy to do this job.
   
   ## Tasks @menghaoranss 
   
   - [ ] move HeartbeatDetect and Handler to control-panel
   - [ ] refactor this mechanism to reuse by jdbc
   - [ ] investigate DataSource pool heartbeat
   - [ ] investigate testQuerySQL and native-ping 
   - [ ] consider integrate DataSource pool heartbeat & native-ping


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] menghaoranss edited a comment on issue #5885: Refactor heartbeat design&implementation

Posted by GitBox <gi...@apache.org>.
menghaoranss edited a comment on issue #5885:
URL: https://github.com/apache/shardingsphere/issues/5885#issuecomment-644704809


   Heartbeat configuration for `springboot` : 
   
   ```
   spring.shardingsphere.cluster.heartbeat.sql=select 1
   spring.shardingsphere.cluster.heartbeat.interval=60
   spring.shardingsphere.cluster.heartbeat.retryEnable=false
   spring.shardingsphere.cluster.heartbeat.retryInterval=3
   spring.shardingsphere.cluster.heartbeat.threadCount=1
   spring.shardingsphere.cluster.heartbeat.retryMaximum=3
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on issue #5885: Refactor heartbeat design&implementation

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #5885:
URL: https://github.com/apache/shardingsphere/issues/5885#issuecomment-637355328


   👍 
   Maybe consider  `move HeartbeatDetect and Handler to  **cluster pacakge of** control-panel`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] menghaoranss edited a comment on issue #5885: Refactor heartbeat design&implementation

Posted by GitBox <gi...@apache.org>.
menghaoranss edited a comment on issue #5885:
URL: https://github.com/apache/shardingsphere/issues/5885#issuecomment-643153009


   @kimmking The second task needs to be split into 4 subtasks:
   - [x] Support jdbc heartbeat detection for `yaml`
   - [x] Support jdbc heartbeat detection for `java config`
   - [x] Support jdbc heartbeat detection for `springboot`
   - [x] Support jdbc heartbeat detection for `namespace`
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] menghaoranss commented on issue #5885: Refactor heartbeat design&implementation

Posted by GitBox <gi...@apache.org>.
menghaoranss commented on issue #5885:
URL: https://github.com/apache/shardingsphere/issues/5885#issuecomment-645221869


   Heartbeat configuration for `spring namespace`:
   ```
   <cluster:heartbeat id="cluster" threadCount="1" interval="60" sql="select 2" retryEnable="true" retryInterval="3" retryMaximum="3"/>
   
   <orchestration:data-source id="shardingDatabasesTablesDataSource" data-source-ref="realShardingDatabasesTablesDataSource" instance-ref="regCenter" overwrite="true" cluster-ref="cluster"/>
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] menghaoranss edited a comment on issue #5885: Refactor heartbeat design&implementation

Posted by GitBox <gi...@apache.org>.
menghaoranss edited a comment on issue #5885:
URL: https://github.com/apache/shardingsphere/issues/5885#issuecomment-643153009


   @kimmking The second task needs to be split into 4 subtasks:
   - [ ] Support jdbc heartbeat detection for `yaml`
   - [ ] Support jdbc heartbeat detection for `java config`
   - [ ] Support jdbc heartbeat detection for `springboot`
   - [ ] Support jdbc heartbeat detection for `namespace`
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] menghaoranss commented on issue #5885: Refactor heartbeat design&implementation

Posted by GitBox <gi...@apache.org>.
menghaoranss commented on issue #5885:
URL: https://github.com/apache/shardingsphere/issues/5885#issuecomment-644705323


   Heartbeat configuration for `yaml`:
   
   ```
   cluster:
     heartbeat:
       sql: select 1
       threadCount: 1
       interval: 60
       retryEnable: false
       retryMaximum: 3
       retryInterval: 3
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] menghaoranss commented on issue #5885: Refactor heartbeat design&implementation

Posted by GitBox <gi...@apache.org>.
menghaoranss commented on issue #5885:
URL: https://github.com/apache/shardingsphere/issues/5885#issuecomment-643153009


   @kimmking The second task needs to be split into 4 subtasks:
   1. Support jdbc heartbeat detection for `yaml`
   2. Support jdbc heartbeat detection for `java config`
   3. Support jdbc heartbeat detection for `springboot`
   4. Support jdbc heartbeat detection for `namespace`
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero edited a comment on issue #5885: Refactor heartbeat design&implementation

Posted by GitBox <gi...@apache.org>.
tristaZero edited a comment on issue #5885:
URL: https://github.com/apache/shardingsphere/issues/5885#issuecomment-637355328


   👍 
   Maybe consider  `move HeartbeatDetect and Handler to  **cluster package of** control-panel` ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] menghaoranss edited a comment on issue #5885: Refactor heartbeat design&implementation

Posted by GitBox <gi...@apache.org>.
menghaoranss edited a comment on issue #5885:
URL: https://github.com/apache/shardingsphere/issues/5885#issuecomment-643153009






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero edited a comment on issue #5885: Refactor heartbeat design&implementation

Posted by GitBox <gi...@apache.org>.
tristaZero edited a comment on issue #5885:
URL: https://github.com/apache/shardingsphere/issues/5885#issuecomment-637355328






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] kimmking closed issue #5885: Refactor heartbeat design&implementation

Posted by GitBox <gi...@apache.org>.
kimmking closed issue #5885:
URL: https://github.com/apache/shardingsphere/issues/5885


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] menghaoranss commented on issue #5885: Refactor heartbeat design&implementation

Posted by GitBox <gi...@apache.org>.
menghaoranss commented on issue #5885:
URL: https://github.com/apache/shardingsphere/issues/5885#issuecomment-637352406


   I will process these tasks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] menghaoranss edited a comment on issue #5885: Refactor heartbeat design&implementation

Posted by GitBox <gi...@apache.org>.
menghaoranss edited a comment on issue #5885:
URL: https://github.com/apache/shardingsphere/issues/5885#issuecomment-643153009


   @kimmking The second task needs to be split into 4 subtasks:
   - [x] Support jdbc heartbeat detection for `yaml`
   - [ ] Support jdbc heartbeat detection for `java config`
   - [ ] Support jdbc heartbeat detection for `springboot`
   - [ ] Support jdbc heartbeat detection for `namespace`
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] menghaoranss commented on issue #5885: Refactor heartbeat design&implementation

Posted by GitBox <gi...@apache.org>.
menghaoranss commented on issue #5885:
URL: https://github.com/apache/shardingsphere/issues/5885#issuecomment-644704809


   Heart beat configuration for `springboot` : 
   
   ```
   spring.shardingsphere.cluster.heartbeat.sql=select 1
   spring.shardingsphere.cluster.heartbeat.interval=60
   spring.shardingsphere.cluster.heartbeat.retryEnable=false
   spring.shardingsphere.cluster.heartbeat.retryInterval=3
   spring.shardingsphere.cluster.heartbeat.threadCount=1
   spring.shardingsphere.cluster.heartbeat.retryMaximum=3
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org