[GitHub] [spark] HyukjinKwon commented on a change in pull request #24540: [SPARK-27253][SQL][FOLLOW-UP] Add a legacy flag to restore old session init behavior

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #24540: [SPARK-27253][SQL][FOLLOW-UP] Add a legacy flag to restore old session init behavior
URL: https://github.com/apache/spark/pull/24540#discussion_r281863684
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/internal/BaseSessionStateBuilder.scala
 ##########
 @@ -85,7 +85,13 @@ abstract class BaseSessionStateBuilder(
    * with its [[SparkConf]] only when there is no parent session.
    */
   protected lazy val conf: SQLConf = {
-    parentState.map(_.conf.clone()).getOrElse {
+    parentState.map { s =>
+      val cloned = s.conf.clone()
+      if (session.conf.get(StaticSQLConf.SQL_LEGACY_SESSION_INIT_WITH_DEFAULTS)) {
 
 Review comment:
   Yup.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org