You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/11 23:41:36 UTC
[GitHub] [arrow-datafusion] realno opened a new pull request #1551: Add covar operators
realno opened a new pull request #1551:
URL: https://github.com/apache/arrow-datafusion/pull/1551
# Which issue does this PR close?
Closes #1548 .
# Rationale for this change
This PR adds `covar`, `covar_pop` and `covar_samp` statistical functions as aggregators to DataFusion.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
The following operators are added:
`covar`
`covar_pop`
`covar_samp`
No breaking changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] realno commented on a change in pull request #1551: Add covar operators
Posted by GitBox <gi...@apache.org>.
realno commented on a change in pull request #1551:
URL: https://github.com/apache/arrow-datafusion/pull/1551#discussion_r782739395
##########
File path: datafusion/src/physical_plan/expressions/stddev.rs
##########
@@ -411,6 +411,62 @@ mod tests {
Ok(())
}
+ #[test]
Review comment:
Added tests for merge rule.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] liukun4515 commented on pull request #1551: Add covar operators
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on pull request #1551:
URL: https://github.com/apache/arrow-datafusion/pull/1551#issuecomment-1011570593
Thank you for your works! @realno
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #1551: Add covar operators
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1551:
URL: https://github.com/apache/arrow-datafusion/pull/1551#issuecomment-1012443447
Thanks @realno @houqp and @liukun4515 -- I didn't review this code but I trust your reviews 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #1551: Add covar operators
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #1551:
URL: https://github.com/apache/arrow-datafusion/pull/1551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] realno commented on a change in pull request #1551: Add covar operators
Posted by GitBox <gi...@apache.org>.
realno commented on a change in pull request #1551:
URL: https://github.com/apache/arrow-datafusion/pull/1551#discussion_r782737912
##########
File path: datafusion/src/physical_plan/expressions/variance.rs
##########
@@ -605,6 +605,62 @@ mod tests {
Ok(())
}
+ #[test]
Review comment:
Added some test for `variance` to test merge rules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org